Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Use ml as a prefix for the ML SCSS variables #25858

Merged
merged 1 commit into from
Nov 19, 2018
Merged

[ML] Use ml as a prefix for the ML SCSS variables #25858

merged 1 commit into from
Nov 19, 2018

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Nov 19, 2018 •
edited
Loading

Summary

Follow-up to #25574, switches the prefix used in the ML _variables.scss file to ml, in line with the prefix used throughout the codebase and ML product.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

@peteharverson peteharverson added review non-issue Indicates to automation that a pull request should not appear in the release notes v7.0.0 :ml Feature:ml-results legacy - do not use v6.6.0 labels Nov 19, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

walterra
walterra approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jgowdyelastic
jgowdyelastic approved these changes Nov 19, 2018
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@peteharverson peteharverson merged commit 7e30709 into elastic:master Nov 19, 2018
@peteharverson peteharverson deleted the ml-scss-variable-prefix branch November 19, 2018 14:08
peteharverson added a commit to peteharverson/kibana that referenced this pull request Nov 19, 2018
@peteharverson
[ML] Use ml as a prefix for the ML SCSS variables (elastic#25858)
1a56240
@peteharverson peteharverson mentioned this pull request Nov 19, 2018
Merged
alvarezmelissa87
alvarezmelissa87 reviewed Nov 19, 2018
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

peteharverson added a commit that referenced this pull request Nov 19, 2018
@peteharverson
[ML] Use ml as a prefix for the ML SCSS variables (#25858) (#25867)
63e021a
@sophiec20 sophiec20 added the Feature:Anomaly Detection ML anomaly detection label Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 left review comments

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@walterra walterra walterra approved these changes

Assignees
No one assigned
Labels
Feature:Anomaly Detection ML anomaly detection Feature:ml-results legacy - do not use :ml non-issue Indicates to automation that a pull request should not appear in the release notes review v6.6.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@peteharverson @elasticmachine @walterra @alvarezmelissa87 @jgowdyelastic @sophiec20