Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[I18n] Translate Timelion - top navigation menu #25801

Merged
merged 1 commit into from
Nov 19, 2018
Merged

[I18n] Translate Timelion - top navigation menu #25801

merged 1 commit into from
Nov 19, 2018

Conversation

LeanidShutau
Copy link
Contributor

@LeanidShutau LeanidShutau added Feature:Timelion Timelion app and visualization Project:i18n v6.6.0 labels Nov 16, 2018
@LeanidShutau LeanidShutau self-assigned this Nov 16, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

timroes
timroes approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Nov 19, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

pavel06081991
pavel06081991 approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeanidShutau LeanidShutau merged commit 2257e06 into elastic:master Nov 19, 2018
@LeanidShutau LeanidShutau deleted the feature/translations/top-nav-menu branch November 19, 2018 11:35
@LeanidShutau LeanidShutau mentioned this pull request Nov 19, 2018
Merged
LeanidShutau added a commit to LeanidShutau/kibana that referenced this pull request Nov 19, 2018
@LeanidShutau
[I18n] Translate Timelion - top navigation menu (elastic#25801)
2affa31
LeanidShutau added a commit that referenced this pull request Nov 19, 2018
@LeanidShutau
[I18n] Translate Timelion - top navigation menu (#25801) (#25864)
b7e4660
@LeanidShutau
Copy link
Contributor Author

6.x/6.6: b7e4660

@LeanidShutau LeanidShutau removed the request for review from maryia-lapata November 19, 2018 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel06081991 pavel06081991 pavel06081991 approved these changes

@timroes timroes timroes approved these changes

Assignees

@LeanidShutau LeanidShutau

Labels
backported Feature:Timelion Timelion app and visualization Project:i18n Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LeanidShutau @elasticmachine @timroes @pavel06081991