[ML] Migrate Timeseries Chart to React #25792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
v7.0.0
:ml
refactoring
Feature:ml-results
|
Pinging @elastic/ml-ui |
walterra
requested review from
jgowdyelastic,
peteharverson and
alvarezmelissa87
peteharverson
approved these changes
Nov 16, 2018
x-pack/plugins/ml/public/timeseriesexplorer/timeseries_chart.js
Outdated
Show resolved
Hide resolved
88 tasks
💚 Build Succeeded |
3 tasks
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Nov 16, 2018
* [ML] Reactified Singleseries Chart. * [ML] Adds an initialization test for TimeseriesChart. * [ML] Restore original behavior of updating focus chart only when interacting with the brush selector. * [ML] Tweaked comments.
walterra
added a commit
that referenced
this pull request
Nov 16, 2018
walterra
added
the
non-issue
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
timeseries_charts.jsas a new file but it's mostly the original d3 code from the angular directive wrapped now in React code. So for the review IMHO I suggest to not focus on all the granular d3 code but just how the React code wraps the previous code. Some code might look verbose, e.g. casting all thethis.*members toconstinside methods; but that allows the original code taken from angular to stay the same and is kind of a safety net to avoid regressions wherethis.somethingcould end up inside another child function without the right context forthis. If you have suggestions for changes to the original d3 code please add comments, I'll document them for a follow up PR in [ML] Migrate Timeseries Viewer Chart to React #25791.Tested:
Checklist
Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)Documentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriatelyPart of #25791 and #18374.