Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Fix agent marks #25717

Merged
merged 2 commits into from
Nov 16, 2018
Merged

[APM] Fix agent marks #25717

merged 2 commits into from
Nov 16, 2018

Conversation

sorenlouv
Copy link
Member

Closes #25712

@sorenlouv sorenlouv added the Team:APM All issues that need APM UI Team support label Nov 15, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

jasonrhodes
jasonrhodes approved these changes Nov 15, 2018
View reviewed changes
Copy link
Member

@jasonrhodes jasonrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

...lic/components/app/TransactionDetails/Transaction/WaterfallContainer/get_agent_marks.test.ts Show resolved Hide resolved
@jasonrhodes jasonrhodes added [zube]: Inbox and removed [zube]: Inbox Team:APM All issues that need APM UI Team support labels Nov 15, 2018
@sorenlouv sorenlouv closed this Nov 15, 2018
@sorenlouv sorenlouv reopened this Nov 15, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@sorenlouv
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@sorenlouv sorenlouv merged commit 83d5a7a into elastic:master Nov 16, 2018
@sorenlouv sorenlouv deleted the fix-agent-marks-issue branch November 16, 2018 07:51
@sorenlouv sorenlouv mentioned this pull request Nov 16, 2018
Merged
sorenlouv added a commit to sorenlouv/kibana that referenced this pull request Nov 16, 2018
@sorenlouv
[APM] Fix agent marks (elastic#25717)
37531e6 
* [APM] Fix agent marks

* Address feedback
sorenlouv added a commit that referenced this pull request Nov 16, 2018
@sorenlouv
[APM] Fix agent marks (#25717) (#25788)
a617293 
* [APM] Fix agent marks

* Address feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonrhodes jasonrhodes jasonrhodes approved these changes

Assignees

@sorenlouv sorenlouv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sorenlouv @elasticmachine @jasonrhodes