Remove lab stage for visualizations #25702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
Feature:Visualizations
|
Pinging @elastic/kibana-app |
💔 Build Failed |
|
Jenkins, test this |
💚 Build Succeeded |
lukeelmers
requested changes
Nov 15, 2018
| @@ -50,23 +50,6 @@ export default ({ getService, getPageObjects }) => { | |||
| expect(await info.getVisibleText()).to.contain('experimental'); | |||
| }); | |||
|
|
|||
| it('should show an notification when creating lab visualizations', async () => { | |||
| // Try to find a lab visualization. | |||
| const labTypes = await PageObjects.visualize.getLabTypeLinks(); | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-Authored-By: timroes <[email protected]>
💚 Build Succeeded |
💚 Build Succeeded |
markov00
approved these changes
Nov 19, 2018
There was a problem hiding this comment.
Code LGTM. Also checked with Tim that the saved-object-finder directive would work correctly using saved objects from previous versions: the type.stage field is applied after loading the saved object so no conflict between lab and experimental happens here.
I've left just a minor minor minor detail comment :)
| if (type.stage === 'lab') { | ||
| prefix = '(Lab)'; | ||
| } else if (type.stage === 'experimental') { | ||
| if (type.stage === 'experimental') { | ||
| prefix = '(Experimental)'; | ||
| } | ||
| return `${prefix} ${type.description}`; |
There was a problem hiding this comment.
This will always have an empty space if there is no prefix.
What about writing something like this:
if(type.stage === 'experimental'){
return `(Experimental) ${type.description}`;
} else {
return type.description;
}There was a problem hiding this comment.
I will ignore your comment for now, since all of that code is already removed in #23833 :-)
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Nov 19, 2018
* Remove lab stage for visualizations * Fix typo Co-Authored-By: timroes <[email protected]> * Remove dead code
timroes
added a commit
that referenced
this pull request
Nov 19, 2018
* Remove lab stage for visualizations * Fix typo Co-Authored-By: timroes <[email protected]> * Remove dead code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the
labstage of visualizations who was initially only introduced so that TSVB can live in it's ownexperimentalstage, that can't be disabled via the advanced settings.This PR now removes
labas a stage and instead makesexperimentalthe stage, that can be disabled via advanced settings. We don't change the settingid(but the description and name), so existing settings, provisioning scripts, etc. won't break.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
Dev Docs
Removal of
labstage for visualizationsWe removed the
labstage for visualizations. Theexperimentalstage is now the only non production stage available, and the one affected by the advanced setting to disable experimental visualizations.Please just change a
stage: 'lab'in your custom vis type tostage: 'experimental', to mark it as non production-ready/experimental.