Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui/chrome/types] add types for setRootController() and some theme methods #25611

Merged
merged 2 commits into from
Nov 14, 2018

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Nov 13, 2018

Just adding definitions for setRootController() and a couple other theme related methods in the ui/chrome types.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@spalger
Copy link
Contributor Author

spalger commented Nov 13, 2018

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger changed the title [ui/chrome] add stub type def for setRootController() [ui/chrome/types] add types for setRootController() and some theme methods Nov 14, 2018
@spalger
Copy link
Contributor Author

spalger commented Nov 14, 2018

tests passed before switching to new PR job

@spalger spalger merged commit c26dc55 into elastic:master Nov 14, 2018
@spalger spalger added the v6.5.1 label Nov 14, 2018
spalger pushed a commit to spalger/kibana that referenced this pull request Nov 14, 2018
…methods (elastic#25611)

* [ui/chrome] add stub type def for `setRootController()`

* [chrome/types] add types for theme related chrome methods
spalger pushed a commit to spalger/kibana that referenced this pull request Nov 14, 2018
…methods (elastic#25611)

* [ui/chrome] add stub type def for `setRootController()`

* [chrome/types] add types for theme related chrome methods
spalger pushed a commit that referenced this pull request Nov 15, 2018
…methods (#25611) (#25671)

* [ui/chrome] add stub type def for `setRootController()`

* [chrome/types] add types for theme related chrome methods
spalger pushed a commit that referenced this pull request Nov 16, 2018
…theme methods (#25611) (#25672)

Backports the following commits to 6.5:
 - [ui/chrome/types] add types for `setRootController()` and some theme methods  (#25611)
@spalger
Copy link
Contributor Author

spalger commented Nov 16, 2018

6.6/6.x: c906550
6.5: cc9f93c

@spalger spalger deleted the types/chrome/setRootController branch November 16, 2018 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants