[kbn-plugin-generator] add eslint-plugin-jsx-a11y to plugin devDeps #25606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…specify react version in config
|
Pinging @elastic/kibana-platform |
💚 Build Succeeded |
azasypkin
reviewed
Nov 14, 2018
|
retest |
💚 Build Succeeded |
azasypkin
approved these changes
Nov 15, 2018
| @@ -1,3 +1,6 @@ | |||
| const semver = require('semver') | |||
There was a problem hiding this comment.
optional nit: ; at the end of the line.
added 2 commits
November 15, 2018 15:35
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Nov 15, 2018
…lastic#25606) * [kbn-plugin-generator] add eslint-plugin-jsx-a11y to plugin devDeps, specify react version in config * [eslint/react] use semver package to coerce version range * fix semicolons
💚 Build Succeeded |
|
6.x/6.6: fd2bcca |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#23932 added a peerDep for
eslint-plugin-jsx-a11ywhich was not being installed automatically via the plugin generator. And the most recent version ofeslint-plugin-reactrequests that the react version be defined in the eslint settings. To make plugin setup as easy as possible I've added these to the plugin generator and shared eslint config.