[Infra UI] Refactor 'capabilites' to 'metadata'. #25580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
weltenwort
approved these changes
Nov 14, 2018
| "One specific capability available on a node. A capability corresponds to a fileset or metricset" | ||
| type InfraNodeCapability { | ||
| export const metadataSchema = gql` | ||
| "One specific metadata information for a node." |
There was a problem hiding this comment.
There is something about information always being plural in english. How about "A metadata entry for a specific node" to circumvent that?
There was a problem hiding this comment.
That's better, thank you.
💔 Build Failed |
skh
force-pushed
the
infraops-refactor-capabilities-metadata
branch
from
b7e1b5c to
2a63391
Compare
|
jenkins, test this |
💔 Build Failed |
skh
force-pushed
the
infraops-refactor-capabilities-metadata
branch
from
2a63391 to
310dd0f
Compare
💚 Build Succeeded |
skh
added a commit
to skh/kibana
that referenced
this pull request
Nov 20, 2018
* Refactor 'capabilites' to 'metadata'. * Better language in inline documentation.
skh
added a commit
that referenced
this pull request
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors all occurences of "capabilities" in GraphQL and the corresponding container to "metadata". Future work will likely rename some parts of this again, to make it more specific what kind of metadata is handled (metric fields, modules, ...), this is just the first step to get rid of the "capabilities" term.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
The only place that uses the affected GraphQL endpoint was adapted.
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriatelyTo test: