Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[I18n] Inject Intl Polyfill to PhantomJS #25465

Merged
merged 8 commits into from
Nov 16, 2018
Merged

[I18n] Inject Intl Polyfill to PhantomJS #25465

merged 8 commits into from
Nov 16, 2018

Conversation

LeanidShutau
Copy link
Contributor

@LeanidShutau LeanidShutau commented Nov 9, 2018 •
edited
Loading

Bug
PhantomJS doesn't have Intl property in the global object, so react-intl throws
[React Intl] The `Intl` APIs must be available in the runtime, and do not appear to be built-in
error.

Fix
Inject Intl polyfill from intl package

@LeanidShutau LeanidShutau added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Project:i18n labels Nov 9, 2018
@LeanidShutau LeanidShutau self-assigned this Nov 9, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@azasypkin azasypkin added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 9, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@LeanidShutau LeanidShutau added the WIP Work in progress label Nov 9, 2018
@LeanidShutau LeanidShutau changed the title [wip][skip ci][I18n] Inject Intl Polyfill to PhantomJS [I18n] Inject Intl Polyfill to PhantomJS Nov 12, 2018
@LeanidShutau LeanidShutau force-pushed the fix/i18n-inject-intl-to-phantom branch from 8fafb62 to c46409c Compare November 12, 2018 08:21
@LeanidShutau LeanidShutau removed the WIP Work in progress label Nov 12, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@LeanidShutau
Copy link
Contributor Author

retest

@LeanidShutau LeanidShutau added the WIP Work in progress label Nov 12, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

This was referenced Nov 13, 2018
Merged
Merged
@elasticmachine
Copy link
Contributor

💔 Build Failed

@LeanidShutau LeanidShutau added v6.6.0 and removed WIP Work in progress labels Nov 15, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

azasypkin
azasypkin reviewed Nov 15, 2018
View reviewed changes
package.json Outdated Show resolved Hide resolved
@azasypkin azasypkin requested a review from tsullivan November 15, 2018 13:35
@azasypkin
Copy link
Member

Hey @tsullivan,

Would you mind taking a look at this PR and let us know if it looks good to you?

Thanks!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

tsullivan
tsullivan approved these changes Nov 15, 2018
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

maryia-lapata
maryia-lapata approved these changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@LeanidShutau thank you for fixing this issue!

@LeanidShutau LeanidShutau merged commit e446097 into elastic:master Nov 16, 2018
@LeanidShutau LeanidShutau deleted the fix/i18n-inject-intl-to-phantom branch November 16, 2018 08:06
@LeanidShutau LeanidShutau mentioned this pull request Nov 16, 2018
Merged
LeanidShutau added a commit to LeanidShutau/kibana that referenced this pull request Nov 16, 2018
@LeanidShutau
[I18n] Inject Intl Polyfill to PhantomJS (elastic#25465)
625de0a 
* [I18n] Inject Intl Polyfill to PhantomJS

* Refactor injection code

* Move intl to "dependencies"

* Move 'intl' to the root 'package.json'

* Fix polyfills paths

* Move intl to x-pack package.json
LeanidShutau added a commit that referenced this pull request Nov 16, 2018
@LeanidShutau
[I18n] Inject Intl Polyfill to PhantomJS (#25465) (#25789)
afbc1ce 
* [I18n] Inject Intl Polyfill to PhantomJS

* Refactor injection code

* Move intl to "dependencies"

* Move 'intl' to the root 'package.json'

* Fix polyfills paths

* Move intl to x-pack package.json
@LeanidShutau
Copy link
Contributor Author

6.x/6.6: afbc1ce

@azasypkin azasypkin mentioned this pull request Nov 26, 2018
Closed
@joshdover joshdover mentioned this pull request Oct 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin left review comments

@maryia-lapata maryia-lapata maryia-lapata approved these changes

@tsullivan tsullivan tsullivan approved these changes

Assignees

@LeanidShutau LeanidShutau

Labels
backported (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LeanidShutau @elasticmachine @azasypkin @tsullivan @maryia-lapata