Remove husky

[mistic]

This PR closes the issue #19576
It basically removes the husky 3rd party dependency and provides a simple way to register a git hook script for the pre-commit.

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[joshdover]

Defensive and clear 👍

[tylersmalley]

For reference, here is the previous pre-commit hook:

#!/bin/sh
# husky
cd .
npm run --json | grep -q '"precommit":'
if [ $? -ne 0 ]; then
  exit 0
fi

npm run precommit --silent

if [ $? -ne 0 ]; then
  echo
  echo "husky - pre-commit hook failed (add --no-verify to bypass)"
  echo
  exit 1
fi

[mistic]

@tylersmalley I just have applied every change we talked about! Do you mind take a look to it again?

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[mistic]

@tylersmalley I just applied every change you suggest! Thanks for the feedback 😃

[mistic]

retest

[tylersmalley]

retest

[tylersmalley]

LGTM

[tylersmalley]

Ah, you will need to update this branch from master.

[mistic]

yeah, done!

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[mistic]

6.x: 4b31c9b

[weltenwort]

Unfortunately this does not seem to be compatible with the git worktree feature. Other than husky, this fails with

Registering Kibana pre-commit git hook...

fail Kibana pre-commit git hook was not installed as an error occur.

ERROR Error: ENOTDIR: not a directory, open '${WORKTREE_DIR}/.git/hooks/pre-commit'
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

    at makeError (${WORKTREE_DIR}/packages/kbn-pm/dist/index.js:19977:9)
    at Promise.all.then.arr (${WORKTREE_DIR}/packages/kbn-pm/dist/index.js:20082:16)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
error Command failed with exit code 1.

because it mistakenly assumes ${WORKTREE_DIR}/.git to be a directory instead of a file as is the case in a worktree.

[weltenwort]

Husky resolves the path from the .git file in https://github.com/typicode/husky/blob/4a9814c04913fc97b6d522cd3765612b9660b668/src/installer/resolveGitDir.ts#L5-L30.

[mistic]

@weltenwort thanks for letting us know about it!

I think maybe we can use git rev-parse --git-dir to reliable get the .git dir location. Is this actually working with your use case for git worktree?

[weltenwort]

git rev-parse --git-dir seems to work, but we could also just learn from husky and spare the subprocess call 😉 for now I'm manually fixing the REPO_ROOT in src/dev/constants.ts.

[mistic]

@weltenwort can you please take a look on #25870 as you were the first reporting this bug? 😃 Thank you very much!