[6.5] [Rollups] Fix i18n bugs (#23848) #24871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Internationalize job details tabs and wrap instances in EuiErrorBoundary to visually localize the error. * Localize no default index pattern message. * Localize es interval errors. * Localize job action menu and confirm delete modal. * Remove unnecessary use of injectI18n from tabs. * Localize job status. * Localize steps. * Remove template literals from FormattedMessages.
💚 Build Succeeded |
jasonrhodes
pushed a commit
to jasonrhodes/kibana
that referenced
this pull request
Oct 31, 2018
* [Rollups] Fix i18n bugs (elastic#23848) * Internationalize job details tabs and wrap instances in EuiErrorBoundary to visually localize the error. * Localize no default index pattern message. * Localize es interval errors. * Localize job action menu and confirm delete modal. * Remove unnecessary use of injectI18n from tabs. * Localize job status. * Localize steps. * Remove template literals from FormattedMessages. * Remove accidental security addition to translation file.
jasonrhodes
added a commit
that referenced
this pull request
Oct 31, 2018
* Polish 6.5 (#24556) * Updates waterfall item design for timeline rows * Adjusts span and tx flyouts and updates tooltips to EUI * Heading size fixes and clean up * Updates tooltip snapshots * Review tweaks and snapshot updates * Revert experiment :) Co-Authored-By: jasonrhodes <[email protected]> * Fixes bug with v1 waterfall state * Fixes bug with timeline bar height * Updates snapshot tests * Updated test so it doesn't mount and rely on EUI makeId() which is non-deterministic per test run * Add a console.error to visualize errors (#24581) (#24867) * [6.5] [Rollups] Fix i18n bugs (#23848) (#24871) * [Rollups] Fix i18n bugs (#23848) * Internationalize job details tabs and wrap instances in EuiErrorBoundary to visually localize the error. * Localize no default index pattern message. * Localize es interval errors. * Localize job action menu and confirm delete modal. * Remove unnecessary use of injectI18n from tabs. * Localize job status. * Localize steps. * Remove template literals from FormattedMessages. * Remove accidental security addition to translation file. * [APM] fixes #24563 by de-duping the column field id 'sample' (#24690) (#24877) * [APM] fixes #24563 by replacing de-duping the twice-used column field id * [APM] fixed issue with service column not sorting in ManagedTable * [APM] make render field on ITableColumn optional and allowing it to use EUI's default value * Add 6.5 to .backportrc.json * [APM] Removes action menus (#24748) * Removes infra links and replaces context menu with single discover links for now * Changes discover links to use empty button style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #23848