Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Read Only Mode in Canvas (#23304) #24367

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Oct 22, 2018

Backports the following commits to 6.x:

* Added readOnly to transient state

* Added check that user has permission to edit when loading workpads

* Shows toolbar in readOnly mode

* Disables page controls in read only mode

* Disables add page button when editing disabled

* Added comment to workpad routes

* Cleaned up page manager styles

* Added a comment to es_persist

* Renamed transient.readOnly to transient.readOnlyUser

* Replaced isEditing in transient state with readOnly in workpad state

* Cleaned up workpad_header

* Fixed logic in workpad_header

* Disables workpad controls instead of hiding them and adds tooltips

* Switched eye icon to lock icon in workpad header

* Renamed readOnly and readOnlyUser variables and functions

* Added dispatch to update canUserWrite in create/clone/delete workpads

* Fixed typo

* Removed unnecessary prop from workpad

* Refactored tooltips in workpad_loader

* Added workpad selector tests
@elasticmachine
Copy link
Contributor

💔 Build Failed

@cqliu1 cqliu1 closed this Oct 23, 2018
@cqliu1 cqliu1 reopened this Oct 23, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cqliu1 cqliu1 merged commit 795c2a6 into elastic:6.x Oct 23, 2018
@cqliu1 cqliu1 deleted the backport/6.x/pr-23304 branch October 23, 2018 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants