Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] move canvas interpreter to core take3 #23994

Closed
wants to merge 37 commits into from
Closed

[WIP] move canvas interpreter to core take3 #23994

wants to merge 37 commits into from

Conversation

ppisljar
Copy link
Member

preparation for #23185

moves some parts of canvas to kibana core:

  • interpreter parse functions are moved to @kbn/interpreter
  • function, render function and type registires are moved to @kbn/interpreter
  • some helper functions are moved to @kbn/interpreter
  • all types are moved to @kbn/interpreter
  • most common functions are moved to @kbn/interpreter
  • browser, location and urlparam browser functions are moved to @kbn/interpreter
  • es_docs and timelion server functions are moved to @kbn/interpreter
  • es_fields, es_indices, get_auth, socket, plugin and translate server routes are moved to the interpreter core_plugin
  • browser socket wrapper is moved to the interpreter core_plugin

qa: nothing should change functionally

ppisljar and others added 30 commits September 25, 2018 07:07
@ppisljar
creating package and plugin
25e26ee
@ppisljar
moving files
6c7c9af
@ppisljar
updating indexes
bb1eee5
@ppisljar
updating licence headers
20794f0
@ppisljar
updating imports
2b61d9b
@ppisljar
linting
0136cc8
@ppisljar
loading core plugin
e0b1e83
@ppisljar
changes to loading canvas
a28988e
@ppisljar
updating package.json
5f2c4c0
@ppisljar
disabling linting in grammar.js
4060e37
@ppisljar
socket needs to wait for all plugins to load their functions before s…
c05ce1d 
…ending the list to the server
@ppisljar
using uuid
6b865b0
moving render function to core
f55bb77
reorganizing core_plugins/interpreter files
7ce3bc8
adding path registry
e46fb85
moving plugins api and using pathsRegistry
26edd41
reverting some earlier changes
0940231
changing plugins server route
57b4ea9
moving and updating loadBrowserPlugins
1443a87
adding register functions
29ddfb0
updating package.json and adding build task
85ae978
cleanup
1bdc96c
adding load_browser_plugins to core/interpreter
68f0a70
removing canvas types (all are registered by core)
c293644
yarn.lock files
40b54bd
adding build:plugins task to core
e8352ca
Merge branch 'master' into ref/moveCanvasInterpreterToCore
6299987 
# Conflicts:
#	x-pack/plugins/canvas/canvas_plugin_src/functions/common/index.js
#	x-pack/yarn.lock
#	yarn.lock
adding @kbn/interpreter to x-pack package.json
d368022
temporary ignoring license check in babel-plugin-mock-imports
6d46879
moving plugin_src from core_plugins to packages/kbn-interpreter
cd4e1ae
ppisljar and others added 7 commits October 10, 2018 17:12
moving peg task
2ed75ad
Merge branch 'master' into ref/moveCanvasInterpreterToCore
2593830 
# Conflicts:
#	package.json
#	packages/kbn-interpreter/plugin_src/functions/server/esdocs/index.js
#	packages/kbn-interpreter/plugin_src/functions/server/timelion.js
#	x-pack/plugins/canvas/canvas_plugin_src/functions/server/esdocs/index.js
#	x-pack/plugins/canvas/canvas_plugin_src/functions/server/src/__tests__/get_expression_type.js
#	x-pack/plugins/canvas/canvas_plugin_src/functions/server/src/__tests__/pointseries.js
#	x-pack/plugins/canvas/canvas_plugin_src/functions/server/src/escount.js
#	x-pack/plugins/canvas/canvas_plugin_src/functions/server/src/esdocs.js
#	x-pack/plugins/canvas/canvas_plugin_src/functions/server/src/pointseries/index.js
#	x-pack/plugins/canvas/canvas_plugin_src/functions/server/src/timelion.js
#	x-pack/plugins/canvas/canvas_plugin_src/functions/server/timelion.js
#	x-pack/plugins/canvas/public/components/font_picker/font_picker.js
#	x-pack/plugins/canvas/tasks/helpers/webpack.plugins.js
fixing package.json
905d5a3
adding kbn:bootstrap task
561f75f
@ppisljar
updating paths
906e1cf
@ppisljar
adding eslint exception
ff364f8
@ppisljar
cleaning globals ?
60b7260
@ghost
Copy link

ghost commented Oct 15, 2018

Hi @ppisljar, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@ppisljar ppisljar mentioned this pull request Oct 15, 2018
Closed
@elasticmachine
Copy link
Contributor

💔 Build Failed

@ppisljar
Copy link
Member Author

closing this in favor of #24041

@ppisljar ppisljar closed this Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ppisljar @elasticmachine