Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old visualization icons #23831

Merged
merged 2 commits into from
Oct 17, 2018
Merged

Remove old visualization icons #23831

merged 2 commits into from
Oct 17, 2018

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Oct 4, 2018

Summary

This PR removes a couple of old visualization icons, that are not used since #22679 anymore.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@timroes timroes requested review from cchaos and lukeelmers October 4, 2018 15:32
@timroes timroes added chore v7.0.0 v6.5.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 4, 2018
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just glanced at which ones were removed and yes those have new EUI counterparts or aren't being used anymore.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@timroes
Copy link
Contributor Author

timroes commented Oct 4, 2018

Jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too. grepped each filename as a sanity check and none of these appear to be in use.

@timroes
Copy link
Contributor Author

timroes commented Oct 17, 2018

Jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@timroes
Copy link
Contributor Author

timroes commented Oct 17, 2018

Jenkins, test this - yarn timed out.. well every day something new

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes timroes merged commit 6b22cd3 into elastic:master Oct 17, 2018
@timroes timroes deleted the remove-icons branch October 17, 2018 12:51
timroes added a commit to timroes/kibana that referenced this pull request Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.5.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants