Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vertical scroll on long legends #23806

Merged

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Oct 4, 2018

Summary

This PR fix #22597

It also remove the vertical overflow, visible with an vertical bar in IE11 on the visualize element, visible on master but not on 6.4 and shown on the following screenshot
screen shot 2018-10-04 at 12 08 00

Checklist

For maintainers

@markov00 markov00 requested a review from A-Hall October 4, 2018 10:11
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@markov00 markov00 added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.0.0 v6.5.0 labels Oct 15, 2018
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@markov00 markov00 requested review from rashmivkulkarni and removed request for bhavyarm October 17, 2018 14:38
@markov00 markov00 force-pushed the fix/issue-22597-vertical-scroll-legend branch from ffa02be to cf37f84 Compare October 18, 2018 14:25
@markov00
Copy link
Member Author

markov00 commented Oct 18, 2018

Hey @marius-dr, can you take a look at this PR on your window machine?

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@markov00
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@markov00 markov00 merged commit cf4996e into elastic:master Nov 19, 2018
markov00 added a commit to markov00/kibana that referenced this pull request Nov 19, 2018
* Fix vertical scroll on long legends

* Fix IE11 global visualize vertical bar
@markov00
Copy link
Member Author

backport 6.x/6.6: #25857

@markov00 markov00 deleted the fix/issue-22597-vertical-scroll-legend branch November 19, 2018 10:49
markov00 added a commit that referenced this pull request Nov 19, 2018
* Fix vertical scroll on long legends

* Fix IE11 global visualize vertical bar
markov00 added a commit to markov00/kibana that referenced this pull request Dec 12, 2018
* Fix vertical scroll on long legends

* Fix IE11 global visualize vertical bar
markov00 added a commit that referenced this pull request Dec 12, 2018
* Fix vertical scroll on long legends

* Fix IE11 global visualize vertical bar
@timroes timroes added the v6.5.4 label Dec 17, 2018
@swtrux
Copy link

swtrux commented Jan 18, 2019

I have tested this on 2 seperate 6.5.4 installs and it is not fixed. When scolling long legends the entire vizualization still scrolls. Also, the problem seems worse now as there is now a large space between the X axis and the actual vizualization(starting x=0) when you make the visual display size less than the size of the legend list. The space becomes larger the smaller you make the size of the visual.

There is also a problem with long X axis legends that did not exist on 5.x.

@flash1293
Copy link
Contributor

Hi @swtrux , there seem to be two very similar issues, one fixed and the other one still lurking - does it work for you in the Visualization Editor? I can reproduce the problem if a vis is used in a dashboard, but the same vis in the editor looks fine for me.

Vis in dashboard with legend scroll bug
screenshot 2019-02-04 at 12 51 06

Same vis in editor with legend overflowing correctly
screenshot 2019-02-04 at 12 53 29

I will open a new PR for the dashboard problem and start working on it right away.

@flash1293
Copy link
Contributor

@swtrux Regarding the problem with long labels ("There is also a problem with long X axis legends that did not exist on 5.x.") - could you please open a separate issue for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.5.4 v6.6.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertical scroll scrolls the entire visualization instead of just the legend.
7 participants