-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vertical scroll on long legends #23806
Fix vertical scroll on long legends #23806
Conversation
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
ffa02be
to
cf37f84
Compare
Hey @marius-dr, can you take a look at this PR on your window machine? |
💚 Build Succeeded |
retest |
💔 Build Failed |
💚 Build Succeeded |
* Fix vertical scroll on long legends * Fix IE11 global visualize vertical bar
backport 6.x/6.6: #25857 |
* Fix vertical scroll on long legends * Fix IE11 global visualize vertical bar
I have tested this on 2 seperate 6.5.4 installs and it is not fixed. When scolling long legends the entire vizualization still scrolls. Also, the problem seems worse now as there is now a large space between the X axis and the actual vizualization(starting x=0) when you make the visual display size less than the size of the legend list. The space becomes larger the smaller you make the size of the visual. There is also a problem with long X axis legends that did not exist on 5.x. |
Hi @swtrux , there seem to be two very similar issues, one fixed and the other one still lurking - does it work for you in the Visualization Editor? I can reproduce the problem if a vis is used in a dashboard, but the same vis in the editor looks fine for me. Vis in dashboard with legend scroll bug Same vis in editor with legend overflowing correctly I will open a new PR for the dashboard problem and start working on it right away. |
@swtrux Regarding the problem with long labels ("There is also a problem with long X axis legends that did not exist on 5.x.") - could you please open a separate issue for that? |
Summary
This PR fix #22597
It also remove the vertical overflow, visible with an vertical bar in IE11 on the visualize element, visible on master but not on 6.4 and shown on the following screenshot
Checklist
[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately