Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix bug in Explorer chart range if selection has too many points #23267

Merged
merged 2 commits into from
Sep 18, 2018
Merged

[ML] Fix bug in Explorer chart range if selection has too many points #23267

merged 2 commits into from
Sep 18, 2018

Conversation

peteharverson
Copy link
Contributor

Fixes a bug introduced in #22967 in the code which restricts the time range of the anomaly chart in the Anomaly Explorer view, if the full selection time range would result in more than the CHART_MAX_POINTS being requested in the Elasticsearch query to get the metric data.

Without this fix, the charts fail to load, with Elasticsearch throwing a org.elasticsearch.search.aggregations.MultiBucketConsumerService$TooManyBucketsException error.

@peteharverson peteharverson added bug Fixes for quality problems that affect the customer experience v7.0.0 :ml Feature:ml-results legacy - do not use v6.5.0 labels Sep 18, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@peteharverson peteharverson added the non-issue Indicates to automation that a pull request should not appear in the release notes label Sep 18, 2018
walterra
walterra approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dear, LGTM.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@peteharverson peteharverson merged commit 19fb3a5 into elastic:master Sep 18, 2018
@peteharverson peteharverson deleted the ml-explorer-charts-max-points branch September 18, 2018 15:08
peteharverson added a commit to peteharverson/kibana that referenced this pull request Sep 18, 2018
@peteharverson
[ML] Fix bug in Explorer chart range if selection has too many points (…
df7bb3b 
…elastic#23267)

* [ML] Fix bug in Explorer chart range if selection has too many points

* [ML] Remove unnecessary newline added in calculateChartRange
@peteharverson peteharverson mentioned this pull request Sep 18, 2018
Merged
peteharverson added a commit that referenced this pull request Sep 19, 2018
@peteharverson
[ML] Fix bug in Explorer chart range if selection has too many points (…
4ac2d08 
…#23267) (#23275)

* [ML] Fix bug in Explorer chart range if selection has too many points

* [ML] Remove unnecessary newline added in calculateChartRange
@sophiec20 sophiec20 added the Feature:Anomaly Detection ML anomaly detection label Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection Feature:ml-results legacy - do not use :ml non-issue Indicates to automation that a pull request should not appear in the release notes v6.5.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peteharverson @elasticmachine @walterra @sophiec20