Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to EUI 3.4.0 #21870

Merged
merged 5 commits into from
Aug 14, 2018
Merged

Upgrade to EUI 3.4.0 #21870

merged 5 commits into from
Aug 14, 2018

Conversation

jen-huang
Copy link
Contributor

Upgrade to EUI 3.4.0 to maintain parity with 6.4 upgrade to EUI 3.0.4 (#21867).

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI
code review, poked around Kibana in chrome

@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 10, 2018

💔 Build Failed

01:38:53    │ proc  [ftr]            └- ✖ fail: "apis xpack_main Settings /api/settings with trial license clusters should load multiple clusters"
01:38:53    │ proc  [ftr]            │       
01:38:53    │ proc  [ftr]            │         Error: expected false to sort of equal true
01:38:53    │ proc  [ftr]            │         + expected - actual
01:38:53    │ proc  [ftr]            │       
01:38:53    │ proc  [ftr]            │         -false
01:38:53    │ proc  [ftr]            │         +true
01:38:53    │ proc  [ftr]            │         
01:38:53    │ proc  [ftr]            │         at Assertion.assert (node_modules/expect.js/index.js:96:13)
01:38:53    │ proc  [ftr]            │         at Assertion.eql (node_modules/expect.js/index.js:230:10)
01:38:53    │ proc  [ftr]            │         at Context.it (test/api_integration/apis/xpack_main/settings/settings.js:37:59)
01:38:53    │ proc  [ftr]            │         at <anonymous>

@jen-huang
Copy link
Contributor Author

Retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@nreese
Copy link
Contributor

nreese commented Aug 10, 2018

Keeps failing on the same test

fail: "apis xpack_main Settings /api/settings with trial license clusters should load multiple clusters"
05:14:23    │ proc  [ftr]            │       
05:14:23    │ proc  [ftr]            │         Error: expected false to sort of equal true
05:14:23    │ proc  [ftr]            │         + expected - actual
05:14:23    │ proc  [ftr]            │       
05:14:23    │ proc  [ftr]            │         -false
05:14:23    │ proc  [ftr]            │         +true

I am also seeing those failures in another PR #21861 so maybe the test is broken in master?

@jen-huang
Copy link
Contributor Author

Yep, it is. #21882 is fixing it.

@jen-huang
Copy link
Contributor Author

Rebased with master to get the above test fix in. 🤞

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@nreese
Copy link
Contributor

nreese commented Aug 14, 2018

jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jen-huang jen-huang merged commit 1e6fb80 into elastic:master Aug 14, 2018
@jen-huang jen-huang deleted the eui-3.4.0 branch August 14, 2018 15:42
jen-huang added a commit to jen-huang/kibana that referenced this pull request Aug 14, 2018
* Upgrade to EUI 3.4.0
* Update snapshots
jen-huang added a commit that referenced this pull request Aug 15, 2018
* Upgrade to EUI 3.4.0
* Update snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants