-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix es unzip #21817
Merged
Merged
Fix es unzip #21817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeDr
added
the
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
label
Aug 8, 2018
tylersmalley
approved these changes
Aug 8, 2018
💚 Build Succeeded |
LeeDr
pushed a commit
to LeeDr/kibana
that referenced
this pull request
Aug 9, 2018
* Rebuild modulePath correctly if on Windows * fix it so we create empty dirs like /logs/
LeeDr
pushed a commit
to LeeDr/kibana
that referenced
this pull request
Aug 9, 2018
* Rebuild modulePath correctly if on Windows * fix it so we create empty dirs like /logs/
LeeDr
pushed a commit
that referenced
this pull request
Aug 9, 2018
LeeDr
pushed a commit
that referenced
this pull request
Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for what I believe to be an Elasticsearch change which breaks our scripts for running a snapshot of Elasticsearch on Windows.
I think Elasticsearch changed to no longer create the /logs/ directory on startup if it doesn't already exist. They shouldn't have to create the /logs/ dir because it's included in the zip and tar.gz archives and/or created by installing the packages.
Our decompress.js wasn't creating empty folders when it unzipped elasticsearch and then elasticsearch wouldn't start.
This change adds mkdir to fix it.
This fixes both
yarn es snapshot
andnode scripts/functional_tests_server
commands which would previously fail (at least on Windows).Part of my output when it fails;