Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix es unzip #21817

Merged
merged 10 commits into from
Aug 9, 2018
Merged

Fix es unzip #21817

merged 10 commits into from
Aug 9, 2018

Conversation

LeeDr
Copy link

@LeeDr LeeDr commented Aug 8, 2018

This is a fix for what I believe to be an Elasticsearch change which breaks our scripts for running a snapshot of Elasticsearch on Windows.

I think Elasticsearch changed to no longer create the /logs/ directory on startup if it doesn't already exist. They shouldn't have to create the /logs/ dir because it's included in the zip and tar.gz archives and/or created by installing the packages.
Our decompress.js wasn't creating empty folders when it unzipped elasticsearch and then elasticsearch wouldn't start.

This change adds mkdir to fix it.

This fixes both yarn es snapshot and node scripts/functional_tests_server commands which would previously fail (at least on Windows).

Part of my output when it fails;

 info  Starting
   │ debg  bin/elasticsearch.bat
   │ info  [0.002s][error][logging] Error opening log file 'logs/gc.log': No such file or directory
   │       Initialization of output 'file=logs/gc.log' using options 'filecount=32,filesize=64m' failed.
   │ERROR  Java HotSpot(TM) 64-Bit Server VM warning: Option UseConcMarkSweepGC was deprecated in version 9.0 and will likely be removed in a future release.
   │       Invalid -Xlog option '-Xlog:gc*,gc+age=trace,safepoint:file=logs/gc.log:utctime,pid,tags:filecount=32,filesize=64m'
   │       Error: Could not create the Java Virtual Machine.
   │       Error: A fatal exception has occurred. Program will exit.

@LeeDr LeeDr added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Aug 8, 2018
@LeeDr LeeDr requested a review from tylersmalley August 8, 2018 21:58
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@LeeDr LeeDr merged commit da1268d into elastic:master Aug 9, 2018
LeeDr pushed a commit to LeeDr/kibana that referenced this pull request Aug 9, 2018
* Rebuild modulePath correctly if on Windows

* fix it so we create empty dirs like /logs/
LeeDr pushed a commit to LeeDr/kibana that referenced this pull request Aug 9, 2018
* Rebuild modulePath correctly if on Windows

* fix it so we create empty dirs like /logs/
LeeDr pushed a commit that referenced this pull request Aug 9, 2018
* Rebuild modulePath correctly if on Windows

* fix it so we create empty dirs like /logs/
LeeDr pushed a commit that referenced this pull request Aug 27, 2018
* Rebuild modulePath correctly if on Windows

* fix it so we create empty dirs like /logs/
@LeeDr LeeDr deleted the fixEsUnzip branch August 20, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants