Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add polyfill for ChildNode remove #21797

Merged
merged 11 commits into from
Aug 10, 2018
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@
"cache-loader": "1.0.3",
"chalk": "^2.4.1",
"check-hash": "1.0.1",
"childnode-remove": "^1.0.1",
"color": "1.0.3",
"commander": "2.8.1",
"compare-versions": "3.1.0",
Expand Down
1 change: 1 addition & 0 deletions src/core_plugins/tests_bundle/tests_entry_template.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import 'babel-polyfill';
import 'custom-event-polyfill';
import 'whatwg-fetch';
import 'abortcontroller-polyfill';
import 'childnode-remove';

import { CoreSystem } from '__kibanaCore__'

Expand Down
1 change: 1 addition & 0 deletions src/ui/ui_bundles/app_entry_template.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import 'babel-polyfill';
import 'custom-event-polyfill';
import 'whatwg-fetch';
import 'abortcontroller-polyfill';
import 'childnode-remove';

import { CoreSystem } from '__kibanaCore__'

Expand Down
22 changes: 22 additions & 0 deletions webpackShims/childnode-remove.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
/*
* Licensed to Elasticsearch B.V. under one or more contributor
* license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright
* ownership. Elasticsearch B.V. licenses this file to you under
* the Apache License, Version 2.0 (the "License"); you may
* not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

const childNodeRemove = require('childnode-remove');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, const childNodeRemove = require('../node_modules/childnode-remove');


childNodeRemove.polyfill();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look at the lib, it doesn't check if remove is already defined. I'd do some light feature detection if possible, native code will most likely be quicker.

4 changes: 4 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2665,6 +2665,10 @@ cheerio@^1.0.0-rc.2:
lodash "^4.15.0"
parse5 "^3.0.1"

childnode-remove@^1.0.1:
version "1.0.1"
resolved "https://registry.yarnpkg.com/childnode-remove/-/childnode-remove-1.0.1.tgz#a3b3aa81a824eb45f4d66bb88f58a330f76068b5"

[email protected]:
version "1.6.0"
resolved "https://registry.yarnpkg.com/chokidar/-/chokidar-1.6.0.tgz#90c32ad4802901d7713de532dc284e96a63ad058"
Expand Down