[ML] Adds Jest tests for the rules editor flyout components #21636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
test
v7.0.0
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui |
💔 Build Failed |
walterra
reviewed
Aug 3, 2018
| jest.mock('../../services/job_service', () => ({ | ||
| mlJobService: { | ||
| getJob: () => { | ||
| return { |
There was a problem hiding this comment.
total nit but this return object could be a separate JSON file which we import. resonates with the idea James' mentioned that something like a mock for mlJobService could be made reusable for other tests.
There was a problem hiding this comment.
Yes, as some of these mocked functions start needing to be reused I agree it would be a good idea to move things like test job configs into separate files. We'd need a wide range of job configs to cover all the things we're testing - here for example I want a detector with no partitioning fields and a single rule.
walterra
approved these changes
Aug 3, 2018
peteharverson
force-pushed
the
ml-rules-editor-tests
branch
from
daf7e8d to
d94f24c
Compare
💚 Build Succeeded |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Aug 6, 2018
peteharverson
added a commit
that referenced
this pull request
Aug 6, 2018
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Jest tests for the components on the rule editor flyout, as used in the Anomalies table, created in #20339.
Tests added for components:
Addresses the first item in #20831