Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #21363

Merged
merged 1 commit into from
Jul 27, 2018
Merged

[email protected] #21363

merged 1 commit into from
Jul 27, 2018

Conversation

snide
Copy link
Contributor

@snide snide commented Jul 27, 2018

This is a patch release of EUI that targets some popover issues in tables / context menus. It also includes the restrictWidth prop addition in 3.0.2 which targets EuiPage (and which makes up the majority of the snapshot updates).

cc @peteharverson

@snide
Copy link
Contributor Author

snide commented Jul 27, 2018

@cchaos Since this is a patch during FF, I'm not adjusting templates to use the new EuiPage stuff. I checked that the old old overwrites (which we used to limit widths) still exist and work.

@snide snide added the blocker label Jul 27, 2018
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah nothing major or breaking here. Visually, fixes some page layouts.

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update LGTM

@snide snide added the bug Fixes for quality problems that affect the customer experience label Jul 27, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@snide snide merged commit 787c7a2 into elastic:master Jul 27, 2018
@snide snide deleted the eui/3.0.3 branch July 27, 2018 18:10
snide added a commit to snide/kibana that referenced this pull request Jul 27, 2018
snide added a commit to snide/kibana that referenced this pull request Jul 27, 2018
Conflicts:
	src/core_plugins/kibana/public/dashboard/listing/__snapshots__/dashboard_listing.test.js.snap
snide added a commit that referenced this pull request Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Fixes for quality problems that affect the customer experience v6.4.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants