Reenable import objects tests #21250

cjcenizal · 2018-07-25T21:45:14Z

Added primary callout to indicate completion of import process when the user has opted to not import anything.

elasticmachine · 2018-07-25T23:39:57Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

cjcenizal · 2018-07-25T23:47:14Z

Intake failure:

22:26:06   1) dev/build/lib/fs copyAll() copies files and directories from source to dest, creating dest if necessary, respecting mode:
22:26:06      Error: expected '755' to equal '777'
22:26:06       at Assertion.assert (node_modules/expect.js/index.js:96:13)
22:26:06       at Assertion.be.Assertion.equal (node_modules/expect.js/index.js:216:10)
22:26:06       at Assertion.(anonymous function) [as be] (node_modules/expect.js/index.js:69:24)
22:26:06       at Context.it (src/dev/build/lib/__tests__/fs.js:228:78)
22:26:06       at <anonymous>

X-Pack failure:

22:21:09   1) ML - validateJob categorization job using mlcategory passes aggregatable field check:
22:21:09 
22:21:09       Error: expected [ 'job_id_valid',
22:21:09   'detectors_function_not_empty',
22:21:09   'index_fields_valid',
22:21:09   'field_not_aggregatable',
22:21:09   'time_field_invalid' ] to sort of equal [ 'job_id_valid',
22:21:09   'detectors_function_not_empty',
22:21:09   'index_fields_valid',
22:21:09   'success_cardinality',
22:21:09   'time_field_invalid',
22:21:09   'influencer_low_suggestion' ]
22:21:09       + expected - actual
22:21:09 
22:21:09        [
22:21:09          "job_id_valid"
22:21:09          "detectors_function_not_empty"
22:21:09          "index_fields_valid"
22:21:09       -  "field_not_aggregatable"
22:21:09       +  "success_cardinality"
22:21:09          "time_field_invalid"
22:21:09       +  "influencer_low_suggestion"
22:21:09        ]
22:21:09       
22:21:09       at Assertion.assert (node_modules/expect.js/index.js:96:13)
22:21:09       at Assertion.eql (node_modules/expect.js/index.js:230:10)
22:21:09       at then.messages (plugins/ml/server/models/job_validation/__tests__/job_validation.js:316:24)
22:21:09       at <anonymous>

cjcenizal · 2018-07-25T23:47:17Z

Retest

…allout to indicate completion of import process when the user has opted to not import anything.

nreese

lgtm
code review

elasticmachine · 2018-07-26T01:21:58Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

cjcenizal · 2018-07-26T01:23:42Z

Retest

elasticmachine · 2018-07-26T02:43:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

cjcenizal · 2018-07-26T02:44:23Z

Retest

elasticmachine · 2018-07-26T04:03:08Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

cjcenizal · 2018-07-26T04:19:10Z

Retest

elasticmachine · 2018-07-26T05:45:13Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

cjcenizal · 2018-07-26T05:57:38Z

Retest

cjcenizal · 2018-07-26T05:58:28Z

Retest

elasticmachine · 2018-07-26T07:20:07Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

cjcenizal · 2018-07-26T12:46:33Z

Retest

elasticmachine · 2018-07-26T14:13:57Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

bmcconaghy

Code LGTM. Please do fix the typo.

bmcconaghy · 2018-07-26T14:31:27Z

test/functional/apps/management/_import_objects.js

      await PageObjects.settings.clickKibanaSavedObjects();

-      // Put in data which already exists
+      // This data has already been loaded by the "visualize" esArchive. We'll load it again
+      // so that we can overriding the existing visualization.


"override" instead of "overriding" here

elasticmachine · 2018-07-26T19:20:55Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

cjcenizal · 2018-07-26T19:34:34Z

Looks like this is a new one:

19:14:20    │ proc  [ftr]        └-> should replace existing filter pill(s) when new item is selected
19:14:20    │ proc  [ftr]          └-> "before each" hook: global before each
19:14:20    │ proc  [ftr]          │ debg  clearComboBox for comboBoxSelector:listControlSelect0
19:14:20    │ proc  [ftr]          │ debg  TestSubjects.find(listControlSelect0)
19:14:20    │ proc  [ftr]          │ debg  findByCssSelector [data-test-subj~="listControlSelect0"]
19:14:30    │ proc  [ftr]          │ debg  TestSubjects.exists(comboBoxOptionsList)
19:14:30    │ proc  [ftr]          │ debg  existsByDisplayedByCssSelector [data-test-subj~="comboBoxOptionsList"]
19:14:31    │ proc  [ftr]          │ debg  TestSubjects.find(listControlSelect0)
19:14:31    │ proc  [ftr]          │ debg  findByCssSelector [data-test-subj~="listControlSelect0"]
19:14:31    │ proc  [ftr]          │ debg  ... sleep(500) start
19:14:31    │ proc  [ftr]          │ debg  ... sleep(500) end
19:14:31    │ proc  [ftr]          │ debg  clickByCssSelector(.euiComboBoxOption)
19:14:31    │ proc  [ftr]          │ debg  findByCssSelector .euiComboBoxOption
19:14:31    │ proc  [ftr]          │ debg  TestSubjects.exists(comboBoxOptionsList)
19:14:31    │ proc  [ftr]          │ debg  existsByDisplayedByCssSelector [data-test-subj~="comboBoxOptionsList"]
19:14:32    │ proc  [ftr]          │ debg  ... sleep(1000) start
19:14:33    │ proc  [ftr]          │ debg  ... sleep(1000) end
19:14:33    │ proc  [ftr]          │ debg  TestSubjects.click(inputControlSubmitBtn)
19:14:33    │ proc  [ftr]          │ debg  TestSubjects.find(inputControlSubmitBtn)
19:14:33    │ proc  [ftr]          │ debg  findByCssSelector [data-test-subj~="inputControlSubmitBtn"]
19:14:33    │ proc  [ftr]          │ debg  isGlobalLoadingIndicatorVisible
19:14:33    │ proc  [ftr]          │ debg  TestSubjects.exists(globalLoadingIndicator)
19:14:33    │ proc  [ftr]          │ debg  existsByDisplayedByCssSelector [data-test-subj~="globalLoadingIndicator"]
19:14:34    │ proc  [ftr]          │ debg  awaitGlobalLoadingIndicatorHidden
19:14:34    │ proc  [ftr]          │ debg  TestSubjects.find(globalLoadingIndicator-hidden)
19:14:34    │ proc  [ftr]          │ debg  findByCssSelector [data-test-subj~="globalLoadingIndicator-hidden"]
19:14:34    │ proc  [ftr]          │ debg  ... sleep(1000) start
19:14:35    │ proc  [ftr]          │ debg  ... sleep(1000) end
19:14:35    │ proc  [ftr]          │ debg  TestSubjects.exists(filter & filter-key-machine.os.raw & filter-value-ios & filter-enabled)
19:14:35    │ proc  [ftr]          │ debg  existsByDisplayedByCssSelector [data-test-subj~="filter"][data-test-subj~="filter-key-machine.os.raw"][data-test-subj~="filter-value-ios"][data-test-subj~="filter-enabled"]
19:14:35    │ proc  [ftr]          │ debg  TestSubjects.exists(filter & filter-key-machine.os.raw & filter-value-osx & filter-enabled)
19:14:35    │ proc  [ftr]          │ debg  existsByDisplayedByCssSelector [data-test-subj~="filter"][data-test-subj~="filter-key-machine.os.raw"][data-test-subj~="filter-value-osx"][data-test-subj~="filter-enabled"]
19:14:36    │ proc  [ftr]          │ info  Taking screenshot "/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/kibana/test/functional/screenshots/failure/visualize app input control visualization updateFiltersOnChange is false should replace existing filter pill_s_ when new item is selected.png"
19:14:36    │ proc  [ftr]          │ info  Current URL is: http://localhost:5620/app/kibana#/visualize/create?type=input_control_vis&_g=(refreshInterval:(pause:!f,value:0),time:(from:%272017-01-01T00:00:00.000Z%27,mode:absolute,to:%272017-01-02T00:00:00.000Z%27))&_a=(filters:!((%27$state%27:(store:appState),meta:(alias:!n,controlledBy:%271532632446377%27,disabled:!f,index:%27logstash-*%27,key:machine.os.raw,negate:!f,params:(query:ios,type:phrase),type:phrase,value:ios),query:(match:(machine.os.raw:(query:ios,type:phrase))))),linked:!f,query:(language:lucene,query:%27%27),uiState:(),vis:(aggs:!(),params:(controls:!((fieldName:machine.os.raw,id:%271532632446377%27,indexPattern:%27logstash-*%27,label:%27%27,options:(dynamicOptions:!t,multiselect:!t,order:desc,size:5,type:terms),parent:%27%27,type:list)),pinFilters:!f,updateFiltersOnChange:!f,useTimeFilter:!f),title:%27New%20Visualization%27,type:input_control_vis))
19:14:36    │ proc  [ftr]          │ info  Saving page source to: /var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-selenium/kibana/test/functional/failure_debug/html/visualize app input control visualization updateFiltersOnChange is false should replace existing filter pill_s_ when new item is selected.html
19:14:36    │ proc  [ftr]        └- ✖ fail: "visualize app input control visualization updateFiltersOnChange is false should replace existing filter pill(s) when new item is selected"
19:14:36    │ proc  [ftr]        │        Error: expected true to equal false
19:14:36    │ proc  [ftr]        │         at Assertion.assert (node_modules/expect.js/index.js:96:13)
19:14:36    │ proc  [ftr]        │         at Assertion.be.Assertion.equal (node_modules/expect.js/index.js:216:10)
19:14:36    │ proc  [ftr]        │         at Context.it (test/functional/apps/visualize/_input_control_vis.js:92:33)
19:14:36    │ proc  [ftr]        │         at <anonymous>
19:14:36    │ proc  [ftr]        │         at process._tickCallback (internal/process/next_tick.js:188:7)

cjcenizal · 2018-07-26T19:34:38Z

Retest

elasticmachine · 2018-07-26T21:07:40Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

cjcenizal · 2018-07-26T21:08:20Z

Retest

elasticmachine · 2018-07-26T23:20:58Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

cjcenizal · 2018-07-26T23:53:32Z

Retest

elasticmachine · 2018-07-27T01:21:10Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* Reenable import objects tests. Refine their assertions. Add primary callout to indicate completion of import process when the user has opted to not import anything.

…tterns (#20379, #20379, #22068, #22029) (#22432) * Add detection of invalid JSON searchSource to saved_object and dashboard (#20379) * Reenable import objects tests (#21250) * Reenable import objects tests. Refine their assertions. Add primary callout to indicate completion of import process when the user has opted to not import anything. * fixing importing saved objects when there's a missing index pattern (#22068) * fixing issue with importing vis with missing saved search (#22029)

cjcenizal added test :Management Team:QA Team label for QA Team v7.0.0 v6.5.0 labels Jul 25, 2018

cjcenizal requested review from nreese and bmcconaghy July 25, 2018 21:45

Reenable import objects tests. Refine their assertions. Add primary c…

5dd2541

…allout to indicate completion of import process when the user has opted to not import anything.

cjcenizal force-pushed the enable-import-objects-test branch from ba121e7 to 5dd2541 Compare July 25, 2018 23:57

nreese approved these changes Jul 26, 2018

View reviewed changes

cjcenizal mentioned this pull request Jul 26, 2018

Functional testing guidelines #9162

Open

bmcconaghy approved these changes Jul 26, 2018

View reviewed changes

Fix typo.

5fe3868

cjcenizal merged commit 5fcd10e into elastic:master Jul 27, 2018

cjcenizal deleted the enable-import-objects-test branch July 27, 2018 01:23

cjcenizal mentioned this pull request Jul 27, 2018

[6.x] Reenable import objects tests (#21250) #21320

Merged

cjcenizal mentioned this pull request Aug 27, 2018

[6.4] Fix bug caused by importing saved objects with missing index patterns (#20379, #20379, #22068, #22029) #22432

Merged

cjcenizal added the v6.4.1 label Aug 27, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reenable import objects tests #21250

Reenable import objects tests #21250

cjcenizal commented Jul 25, 2018

elasticmachine commented Jul 25, 2018

cjcenizal commented Jul 25, 2018 •

edited

Loading

cjcenizal commented Jul 25, 2018

nreese left a comment

elasticmachine commented Jul 26, 2018

cjcenizal commented Jul 26, 2018

elasticmachine commented Jul 26, 2018

cjcenizal commented Jul 26, 2018

elasticmachine commented Jul 26, 2018

cjcenizal commented Jul 26, 2018

elasticmachine commented Jul 26, 2018

cjcenizal commented Jul 26, 2018

cjcenizal commented Jul 26, 2018

elasticmachine commented Jul 26, 2018

cjcenizal commented Jul 26, 2018

elasticmachine commented Jul 26, 2018

bmcconaghy left a comment

bmcconaghy Jul 26, 2018

elasticmachine commented Jul 26, 2018

cjcenizal commented Jul 26, 2018

cjcenizal commented Jul 26, 2018

elasticmachine commented Jul 26, 2018

cjcenizal commented Jul 26, 2018

elasticmachine commented Jul 26, 2018

cjcenizal commented Jul 26, 2018

elasticmachine commented Jul 27, 2018

Reenable import objects tests #21250

Reenable import objects tests #21250

Conversation

cjcenizal commented Jul 25, 2018

elasticmachine commented Jul 25, 2018

💔 Build Failed

cjcenizal commented Jul 25, 2018 • edited Loading

cjcenizal commented Jul 25, 2018

nreese left a comment

Choose a reason for hiding this comment

elasticmachine commented Jul 26, 2018

💚 Build Succeeded

cjcenizal commented Jul 26, 2018

elasticmachine commented Jul 26, 2018

💚 Build Succeeded

cjcenizal commented Jul 26, 2018

elasticmachine commented Jul 26, 2018

💚 Build Succeeded

cjcenizal commented Jul 26, 2018

elasticmachine commented Jul 26, 2018

💚 Build Succeeded

cjcenizal commented Jul 26, 2018

cjcenizal commented Jul 26, 2018

elasticmachine commented Jul 26, 2018

💚 Build Succeeded

cjcenizal commented Jul 26, 2018

elasticmachine commented Jul 26, 2018

💚 Build Succeeded

bmcconaghy left a comment

Choose a reason for hiding this comment

bmcconaghy Jul 26, 2018

Choose a reason for hiding this comment

elasticmachine commented Jul 26, 2018

💔 Build Failed

cjcenizal commented Jul 26, 2018

cjcenizal commented Jul 26, 2018

elasticmachine commented Jul 26, 2018

💚 Build Succeeded

cjcenizal commented Jul 26, 2018

elasticmachine commented Jul 26, 2018

💚 Build Succeeded

cjcenizal commented Jul 26, 2018

elasticmachine commented Jul 27, 2018

💚 Build Succeeded

cjcenizal commented Jul 25, 2018 •

edited

Loading