Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Renaming jobs list directory #21130

Merged

Conversation

jgowdyelastic
Copy link
Member

Rather than removing the old jobs list, for 6.4 we have decided to keep it as a hidden page accessible through the url <kibana>/app/ml#/jobs_old
However to prepare for it's eventual removal, we can rename its directory to jobs_list_old
Up to now, the new jobs list has be in a directory called jobs_list_new, this can now be renamed to plain old jobs_list

In summary:
jobs_list -> jobs_list_old
jobs_list_new -> jobs_list

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@jgowdyelastic jgowdyelastic changed the title [ML] Renaming jobs list new to jobs list [ML] Renaming jobs list directory Jul 24, 2018
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jgowdyelastic jgowdyelastic force-pushed the renaming-jobs-list-new-to-jobs-list branch from c8ec095 to 7f6359b Compare July 24, 2018 11:47
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jgowdyelastic jgowdyelastic merged commit b4056bb into elastic:master Jul 24, 2018
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Jul 24, 2018
* [ML] Renaming jobs list new to jobs list

* moving missing files
@jgowdyelastic
Copy link
Member Author

Related to #20150

jgowdyelastic added a commit that referenced this pull request Jul 24, 2018
* [ML] Renaming jobs list new to jobs list

* moving missing files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants