-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Renaming jobs list directory #21130
Merged
jgowdyelastic
merged 2 commits into
elastic:master
from
jgowdyelastic:renaming-jobs-list-new-to-jobs-list
Jul 24, 2018
Merged
[ML] Renaming jobs list directory #21130
jgowdyelastic
merged 2 commits into
elastic:master
from
jgowdyelastic:renaming-jobs-list-new-to-jobs-list
Jul 24, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
review
v7.0.0
v6.4.0
:ml
Feature:Anomaly Detection
ML anomaly detection
labels
Jul 24, 2018
Pinging @elastic/ml-ui |
jgowdyelastic
changed the title
[ML] Renaming jobs list new to jobs list
[ML] Renaming jobs list directory
Jul 24, 2018
peteharverson
approved these changes
Jul 24, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
walterra
approved these changes
Jul 24, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded |
jgowdyelastic
force-pushed
the
renaming-jobs-list-new-to-jobs-list
branch
from
July 24, 2018 11:47
c8ec095
to
7f6359b
Compare
💔 Build Failed |
💚 Build Succeeded |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Jul 24, 2018
* [ML] Renaming jobs list new to jobs list * moving missing files
Related to #20150 |
jgowdyelastic
added a commit
that referenced
this pull request
Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than removing the old jobs list, for 6.4 we have decided to keep it as a hidden page accessible through the url
<kibana>/app/ml#/jobs_old
However to prepare for it's eventual removal, we can rename its directory to
jobs_list_old
Up to now, the new jobs list has be in a directory called
jobs_list_new
, this can now be renamed to plain oldjobs_list
In summary:
jobs_list
->jobs_list_old
jobs_list_new
->jobs_list