Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Adding rules and filters permission checks #21097

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Jul 23, 2018

If the user does not have the permission to get filters, the link in settings is disabled:

image

If the user doesn't have permission to update a job, the configure rules link is removed from the menu.

image

If the user doesn't have permission to get the filters list, the scope section is disabled and a callout displayed.

image

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. LGTM!

@jgowdyelastic jgowdyelastic merged commit 770ff20 into elastic:master Jul 24, 2018
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Jul 24, 2018
* [ML] Adding rules and filters permission checks

* fixing disabled link check
jgowdyelastic added a commit that referenced this pull request Jul 24, 2018
* [ML] Adding rules and filters permission checks

* fixing disabled link check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants