-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Adding rules and filters permission checks #21097
Merged
jgowdyelastic
merged 2 commits into
elastic:master
from
jgowdyelastic:adding-rules-and-filters-permission-checks
Jul 24, 2018
Merged
[ML] Adding rules and filters permission checks #21097
jgowdyelastic
merged 2 commits into
elastic:master
from
jgowdyelastic:adding-rules-and-filters-permission-checks
Jul 24, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
review
v7.0.0
v6.4.0
:ml
Feature:Anomaly Detection
ML anomaly detection
labels
Jul 23, 2018
Pinging @elastic/ml-ui |
💚 Build Succeeded |
walterra
approved these changes
Jul 24, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
peteharverson
approved these changes
Jul 24, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. LGTM!
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Jul 24, 2018
* [ML] Adding rules and filters permission checks * fixing disabled link check
jgowdyelastic
added a commit
that referenced
this pull request
Jul 24, 2018
This was referenced Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user does not have the permission to get filters, the link in settings is disabled:
If the user doesn't have permission to update a job, the
configure rules
link is removed from the menu.If the user doesn't have permission to get the filters list, the scope section is disabled and a callout displayed.