[ML] Better handling of job request timeouts #20985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
review
v7.0.0
v6.4.0
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui |
💚 Build Succeeded |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Jul 19, 2018
jgowdyelastic
added a commit
that referenced
this pull request
Jul 19, 2018
|
Related to #20150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing actions on multiple jobs, the jobs are looped over and run synchronously to avoid strain on the server.
There is a 30s timeout when calling java endpoints and if any of these hit the timeout, the loop will progress to the next job causing a situation where multiple requests are running at the same time.
This change causes the loop to break and return timeout failures for all of the jobs which haven't yet been dealt with.
Also moves groups
getAllGroupsinto it's own file and slightly adjusts the width of a column to accommodatehard_limitandsoft_limitmemory statuses.Unit tests to follow in a subsequent PR.