Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the way new platform is integrated into legacy one. #20925

Merged
merged 2 commits into from
Jul 19, 2018
Merged

Document the way new platform is integrated into legacy one. #20925

merged 2 commits into from
Jul 19, 2018

Conversation

azasypkin
Copy link
Member

Brief explanation of the way core works with the "legacy" Kibana.

Fixes #14870

@azasypkin azasypkin added review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform v6.4.0 labels Jul 18, 2018
@azasypkin azasypkin requested review from epixa and spalger July 18, 2018 11:41
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

epixa
epixa approved these changes Jul 18, 2018
View reviewed changes
Copy link
Contributor

@epixa epixa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "Even though new system provided by the core is... " seems like an awkward way to word this. Perhaps "Even though the new validation system provided by the core is... "

LGTM though. If you do make the change above, I don't need to review again.

@azasypkin
Copy link
Member Author

nit: "Even though new system provided by the core is... " seems like an awkward way to word this. Perhaps "Even though the new validation system provided by the core is... "

Thanks, fixed!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

spalger
spalger approved these changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azasypkin azasypkin merged commit b4b55bd into elastic:master Jul 19, 2018
@azasypkin azasypkin deleted the issue-14870-core-readme branch July 19, 2018 05:48
azasypkin added a commit to azasypkin/kibana that referenced this pull request Jul 19, 2018
@azasypkin
Document the way new platform is integrated into legacy one. (elastic…
24662d6 
…#20925)
@azasypkin azasypkin mentioned this pull request Jul 19, 2018
Merged
@azasypkin
Copy link
Member Author

6.x/6.4: b8cf079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

@epixa epixa epixa approved these changes

Assignees
No one assigned
Labels
backported Feature:New Platform review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@azasypkin @elasticmachine @epixa @spalger