Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use current in documentation link service #208867

Merged
merged 5 commits into from
Jan 30, 2025
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 30, 2025

Summary

Relates to elastic/docs#3160

This PR updates the doc link service to use "current" instead of "main" or "master", since we are going to stop publishing those versions on the existing documentation site.

It also updates hard-coded links that were failing jest tests (and ideally should be updated to use the doc link service and its mock service or else they need to be updated again when the new doc URLs are finalized).

@lcawl lcawl added Team:Docs backport:skip This commit does not require backporting docs labels Jan 30, 2025
@lcawl lcawl marked this pull request as ready for review January 30, 2025 00:20
@lcawl lcawl requested a review from a team as a code owner January 30, 2025 00:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@lcawl lcawl added the release_note:skip Skip the PR/issue when compiling release notes label Jan 30, 2025
@lcawl lcawl enabled auto-merge (squash) January 30, 2025 01:18
@lcawl lcawl requested review from a team as code owners January 30, 2025 04:14
@botelastic botelastic bot added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Jan 30, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #6 / FileDeleteButton isIcon clicking delete button opens the confirmation modal

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiAssistantManagementSelection 93.7KB 93.7KB +1.0B
lens 1.6MB 1.6MB +1.0B
lists 143.2KB 143.2KB +1.0B
ml 4.7MB 4.7MB +1.0B
profiling 406.9KB 406.9KB +1.0B
synthetics 920.8KB 920.8KB +1.0B
total +6.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 484.2KB 484.2KB +1.0B

History

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lcawl lcawl disabled auto-merge January 30, 2025 17:06
@lcawl lcawl merged commit bc5e893 into elastic:main Jan 30, 2025
8 checks passed
@lcawl lcawl deleted the doc-link-current branch January 30, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting docs release_note:skip Skip the PR/issue when compiling release notes Team:Docs Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants