[Search][Configuration] Remove Enterprise Search node values #208856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TattdCodeMonkey
added
release_note:skip
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
TattdCodeMonkey
force-pushed
the
search/remove-ent-search-config-values
branch
from
bca7c0d to
7b05515
Compare
TattdCodeMonkey
commented
Jan 29, 2025
x-pack/solutions/search/plugins/enterprise_search/server/config.ts
Outdated
Show resolved
Hide resolved
TattdCodeMonkey
commented
Jan 29, 2025
x-pack/solutions/search/plugins/enterprise_search/server/config.ts
Outdated
Show resolved
Hide resolved
jbudz
approved these changes
Jan 29, 2025
efegurkan
approved these changes
Jan 29, 2025
TattdCodeMonkey
force-pushed
the
search/remove-ent-search-config-values
branch
from
7b05515 to
3c15c7c
Compare
elena-shostak
approved these changes
Jan 30, 2025
TattdCodeMonkey
added
backport:version
TattdCodeMonkey
force-pushed
the
search/remove-ent-search-config-values
branch
from
4094fe4 to
a4d5a4d
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Public APIs missing comments
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
|
|
Starting backport for target branches: 9.1 https://github.com/elastic/kibana/actions/runs/13059770731 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
TattdCodeMonkey
added a commit
to TattdCodeMonkey/kibana
that referenced
this pull request
Jan 31, 2025
…#208856) ## Summary This removes the config values associated with the enterprise search node. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) (cherry picked from commit 26fac70)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
TattdCodeMonkey
added a commit
to TattdCodeMonkey/kibana
that referenced
this pull request
Jan 31, 2025
…#208856) ## Summary This removes the config values associated with the enterprise search node. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) (cherry picked from commit 26fac70)
TattdCodeMonkey
added a commit
to TattdCodeMonkey/kibana
that referenced
this pull request
Feb 3, 2025
…#208856) ## Summary This removes the config values associated with the enterprise search node. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) (cherry picked from commit 26fac70)
TattdCodeMonkey
added a commit
that referenced
this pull request
Feb 3, 2025
…208856) (#209147) # Backport This will backport the following commits from `main` to `9.0`: - [[Search][Configuration] Remove Enterprise Search node values (#208856)](#208856) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Rodney Norris","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-30T19:28:26Z","message":"[Search][Configuration] Remove Enterprise Search node values (#208856)\n\n## Summary\r\n\r\nThis removes the config values associated with the enterprise search\r\nnode.\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)","sha":"26fac70c9b82d65de1b93acf6be4d28503fb9f6a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:version","v9.1.0"],"title":"[Search][Configuration] Remove Enterprise Search node values","number":208856,"url":"https://github.com/elastic/kibana/pull/208856","mergeCommit":{"message":"[Search][Configuration] Remove Enterprise Search node values (#208856)\n\n## Summary\r\n\r\nThis removes the config values associated with the enterprise search\r\nnode.\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)","sha":"26fac70c9b82d65de1b93acf6be4d28503fb9f6a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208856","number":208856,"mergeCommit":{"message":"[Search][Configuration] Remove Enterprise Search node values (#208856)\n\n## Summary\r\n\r\nThis removes the config values associated with the enterprise search\r\nnode.\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)","sha":"26fac70c9b82d65de1b93acf6be4d28503fb9f6a"}},{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
TattdCodeMonkey
added a commit
that referenced
this pull request
Feb 3, 2025
…08972) ## Summary Add `enterpriseSearch` config deprecations for items remove in 9.0. This is paired with #208856 which removes all the listed values from the `enterprise_search` plugin configuration. ### Screenshots 
TattdCodeMonkey
added a commit
to TattdCodeMonkey/kibana
that referenced
this pull request
Feb 5, 2025
…astic#208972) ## Summary Add `enterpriseSearch` config deprecations for items remove in 9.0. This is paired with elastic#208856 which removes all the listed values from the `enterprise_search` plugin configuration. ### Screenshots  (cherry picked from commit a2329a3)
TattdCodeMonkey
added a commit
that referenced
this pull request
Feb 5, 2025
…9.0 (#208972) (#209809) # Backport This will backport the following commits from `8.x` to `8.18`: - [Search: add deprecation warnings for config values removed in 9.0 (#208972)](#208972) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Rodney Norris","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-03T19:44:01Z","message":"Search: add deprecation warnings for config values removed in 9.0 (#208972)\n\n## Summary\r\n\r\nAdd `enterpriseSearch` config deprecations for items remove in 9.0.\r\n\r\nThis is paired with #208856 which removes all the listed values from the\r\n`enterprise_search` plugin configuration.\r\n\r\n### Screenshots\r\n\r\n","sha":"a2329a376524ac80480b1a3c6e77b0d6dae31381"},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:skip"],"title":"Update dependency chromedriver to ^132.0.2 (8.x)","number":208938,"url":"https://github.com/elastic/kibana/pull/208938"},"sourceBranch":"8.x","suggestedTargetBranches":[],"targetPullRequestStates":[]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes the config values associated with the enterprise search node.
Checklist