Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Synthetics] Fix ping heatmap regression when Inspect flag is turned off !! (#208726) #208796

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…off !! (elastic#208726)

## Summary

Fixes elastic#208304 !!

Fix ping heatmap regression when Inspect flag is turned off !!

This flag is turned on auto in dev which caused an issue !!

To reproduce the step, you can turn off the inspect flag in dev mode by
removing `this.isDev `from this condition

https://github.com/elastic/kibana/blob/main/x-pack/solutions/observability/plugins/synthetics/server/lib.ts#L93

### After

<img width="1726" alt="image"
src="https://github.com/user-attachments/assets/ad786351-37e4-4c18-b68e-695880d836e9"
/>

(cherry picked from commit 557cac2)
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@shahzad31 shahzad31 disabled auto-merge January 29, 2025 16:43
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @shahzad31

@shahzad31 shahzad31 merged commit 5d715ad into elastic:8.x Jan 30, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants