Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16] [Synthetics] Fix ping heatmap regression when Inspect flag is turned off !! (#208726) #208794

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.16:

Questions ?

Please refer to the Backport tool documentation

…off !! (elastic#208726)

## Summary

Fixes elastic#208304 !!

Fix ping heatmap regression when Inspect flag is turned off !!

This flag is turned on auto in dev which caused an issue !!

To reproduce the step, you can turn off the inspect flag in dev mode by
removing `this.isDev `from this condition

https://github.com/elastic/kibana/blob/main/x-pack/solutions/observability/plugins/synthetics/server/lib.ts#L93

### After

<img width="1726" alt="image"
src="https://github.com/user-attachments/assets/ad786351-37e4-4c18-b68e-695880d836e9"
/>

(cherry picked from commit 557cac2)
@kibanamachine kibanamachine enabled auto-merge (squash) January 29, 2025 16:41
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Jan 29, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 29, 2025

💚 Build Succeeded

  • Buildkite Build
  • Commit: 9721d85
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-208794-9721d859d3ce

Metrics [docs]

✅ unchanged

History

cc @shahzad31

@shahzad31 shahzad31 merged commit 88d8fef into elastic:8.16 Jan 30, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants