bump react@18 #208339
Closed
bump react@18 #208339
+272
−267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Dosant
added a commit
that referenced
this pull request
Jan 27, 2025
…t@18 (#208387) ## Summary Part of #206952 Fixes when run with React@18 #208339 (comment): [[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055) [[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4701-478b-93ef-9013f7210234) Jest Integration Tests / request flyout renders _meta field [[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055) [[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4702-4357-a67e-d59c6bb5f12b) Jest Integration Tests / request flyout renders a json with default policy name when only policy name is missing [[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055) [[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4701-4d18-8c34-1f4965486aa1) Jest Integration Tests / request flyout renders an error callout if policy form is invalid [[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055) [[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4701-4533-9e12-e7056e8277aa) Jest Integration Tests / request flyout renders the correct json and name for a new policy To run with React@18 use: ``` REACT_18=true yarn test:jest_integration x-pack/platform/plugins/private/index_lifecycle_management/integration_tests/edit_policy/features/request_flyout.test.ts ``` I tested that the component works in the browser, so the issue is in the test. I think that because of some internal React@18 changes the order in which the validation timeout inside our form lib is called conflcts with fake timers (the timeout just stucks). So instead of trying to add additional `jest.advanceTimersByTime(0);` in some places I decided to simplify and just use the real timeouts that works well for both react@17 an react@18
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 27, 2025
…t@18 (elastic#208387) ## Summary Part of elastic#206952 Fixes when run with React@18 elastic#208339 (comment): [[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055) [[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4701-478b-93ef-9013f7210234) Jest Integration Tests / request flyout renders _meta field [[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055) [[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4702-4357-a67e-d59c6bb5f12b) Jest Integration Tests / request flyout renders a json with default policy name when only policy name is missing [[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055) [[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4701-4d18-8c34-1f4965486aa1) Jest Integration Tests / request flyout renders an error callout if policy form is invalid [[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055) [[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4701-4533-9e12-e7056e8277aa) Jest Integration Tests / request flyout renders the correct json and name for a new policy To run with React@18 use: ``` REACT_18=true yarn test:jest_integration x-pack/platform/plugins/private/index_lifecycle_management/integration_tests/edit_policy/features/request_flyout.test.ts ``` I tested that the component works in the browser, so the issue is in the test. I think that because of some internal React@18 changes the order in which the validation timeout inside our form lib is called conflcts with fake timers (the timeout just stucks). So instead of trying to add additional `jest.advanceTimersByTime(0);` in some places I decided to simplify and just use the real timeouts that works well for both react@17 an react@18 (cherry picked from commit 9e8ab66)
kibanamachine
added a commit
that referenced
this pull request
Jan 27, 2025
…h React@18 (#208387) (#208416) # Backport This will backport the following commits from `main` to `8.x`: - [[React@18] Fix index management unit tests that are failing with React@18 (#208387)](#208387) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-27T17:21:44Z","message":"[React@18] Fix index management unit tests that are failing with React@18 (#208387)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/206952\r\n\r\nFixes when run with React@18\r\nhttps://github.com//pull/208339#issuecomment-2615621371:\r\n\r\n\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4701-478b-93ef-9013f7210234)\r\nJest Integration Tests / request flyout renders _meta field\r\n\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4702-4357-a67e-d59c6bb5f12b)\r\nJest Integration Tests / request flyout renders a json with default\r\npolicy name when only policy name is missing\r\n\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4701-4d18-8c34-1f4965486aa1)\r\nJest Integration Tests / request flyout renders an error callout if\r\npolicy form is invalid\r\n\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4701-4533-9e12-e7056e8277aa)\r\nJest Integration Tests / request flyout renders the correct json and\r\nname for a new policy\r\n\r\n\r\n\r\nTo run with React@18 use: \r\n\r\n```\r\nREACT_18=true yarn test:jest_integration x-pack/platform/plugins/private/index_lifecycle_management/integration_tests/edit_policy/features/request_flyout.test.ts\r\n```\r\n\r\nI tested that the component works in the browser, so the issue is in the\r\ntest. I think that because of some internal React@18 changes the order\r\nin which the validation timeout inside our form lib is called conflcts\r\nwith fake timers (the timeout just stucks). So instead of trying to add\r\nadditional `jest.advanceTimersByTime(0);` in some places I decided to\r\nsimplify and just use the real timeouts that works well for both\r\nreact@17 an react@18","sha":"9e8ab663b76aa99b9482fb2bbe17f8cf0e1d4238","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","React@18"],"title":"[React@18] Fix index management unit tests that are failing with React@18","number":208387,"url":"https://github.com/elastic/kibana/pull/208387","mergeCommit":{"message":"[React@18] Fix index management unit tests that are failing with React@18 (#208387)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/206952\r\n\r\nFixes when run with React@18\r\nhttps://github.com//pull/208339#issuecomment-2615621371:\r\n\r\n\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4701-478b-93ef-9013f7210234)\r\nJest Integration Tests / request flyout renders _meta field\r\n\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4702-4357-a67e-d59c6bb5f12b)\r\nJest Integration Tests / request flyout renders a json with default\r\npolicy name when only policy name is missing\r\n\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4701-4d18-8c34-1f4965486aa1)\r\nJest Integration Tests / request flyout renders an error callout if\r\npolicy form is invalid\r\n\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4701-4533-9e12-e7056e8277aa)\r\nJest Integration Tests / request flyout renders the correct json and\r\nname for a new policy\r\n\r\n\r\n\r\nTo run with React@18 use: \r\n\r\n```\r\nREACT_18=true yarn test:jest_integration x-pack/platform/plugins/private/index_lifecycle_management/integration_tests/edit_policy/features/request_flyout.test.ts\r\n```\r\n\r\nI tested that the component works in the browser, so the issue is in the\r\ntest. I think that because of some internal React@18 changes the order\r\nin which the validation timeout inside our form lib is called conflcts\r\nwith fake timers (the timeout just stucks). So instead of trying to add\r\nadditional `jest.advanceTimersByTime(0);` in some places I decided to\r\nsimplify and just use the real timeouts that works well for both\r\nreact@17 an react@18","sha":"9e8ab663b76aa99b9482fb2bbe17f8cf0e1d4238"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208387","number":208387,"mergeCommit":{"message":"[React@18] Fix index management unit tests that are failing with React@18 (#208387)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/206952\r\n\r\nFixes when run with React@18\r\nhttps://github.com//pull/208339#issuecomment-2615621371:\r\n\r\n\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4701-478b-93ef-9013f7210234)\r\nJest Integration Tests / request flyout renders _meta field\r\n\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4702-4357-a67e-d59c6bb5f12b)\r\nJest Integration Tests / request flyout renders a json with default\r\npolicy name when only policy name is missing\r\n\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4701-4d18-8c34-1f4965486aa1)\r\nJest Integration Tests / request flyout renders an error callout if\r\npolicy form is invalid\r\n\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-2649-4cd6-bac8-5f186c246055)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-2649-4cd6-bac8-5f186c246055/artifacts/0194a7ae-4701-4533-9e12-e7056e8277aa)\r\nJest Integration Tests / request flyout renders the correct json and\r\nname for a new policy\r\n\r\n\r\n\r\nTo run with React@18 use: \r\n\r\n```\r\nREACT_18=true yarn test:jest_integration x-pack/platform/plugins/private/index_lifecycle_management/integration_tests/edit_policy/features/request_flyout.test.ts\r\n```\r\n\r\nI tested that the component works in the browser, so the issue is in the\r\ntest. I think that because of some internal React@18 changes the order\r\nin which the validation timeout inside our form lib is called conflcts\r\nwith fake timers (the timeout just stucks). So instead of trying to add\r\nadditional `jest.advanceTimersByTime(0);` in some places I decided to\r\nsimplify and just use the real timeouts that works well for both\r\nreact@17 an react@18","sha":"9e8ab663b76aa99b9482fb2bbe17f8cf0e1d4238"}}]}] BACKPORT--> Co-authored-by: Anton Dosov <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jan 28, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[React@18] follow up fix tty test (#208393)](#208393) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-28T11:08:17Z","message":"[React@18] follow up fix tty test (#208393)\n\n## Summary\r\n\r\nThis piece was left out from the\r\nhttps://github.com//pull/206919 (I assume by mistake)\r\nthis waitFor is needed for testing passing with React@18, see\r\nhttps://github.com//pull/208339/files#diff-bf9743a8d3aa8ed102d36f9117fb14e455efa23df7da28a4ac44b7efa270899a\r\n\r\n\r\n```\r\nREACT_18=true yarn test:jest x-pack/solutions/security/plugins/session_view/public/components/tty_player/hooks.test.tsx\r\n```","sha":"fc179a8d47b7a7ab622dfce519154175b1821869","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","React@18"],"title":"[React@18] follow up fix tty test","number":208393,"url":"https://github.com/elastic/kibana/pull/208393","mergeCommit":{"message":"[React@18] follow up fix tty test (#208393)\n\n## Summary\r\n\r\nThis piece was left out from the\r\nhttps://github.com//pull/206919 (I assume by mistake)\r\nthis waitFor is needed for testing passing with React@18, see\r\nhttps://github.com//pull/208339/files#diff-bf9743a8d3aa8ed102d36f9117fb14e455efa23df7da28a4ac44b7efa270899a\r\n\r\n\r\n```\r\nREACT_18=true yarn test:jest x-pack/solutions/security/plugins/session_view/public/components/tty_player/hooks.test.tsx\r\n```","sha":"fc179a8d47b7a7ab622dfce519154175b1821869"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208393","number":208393,"mergeCommit":{"message":"[React@18] follow up fix tty test (#208393)\n\n## Summary\r\n\r\nThis piece was left out from the\r\nhttps://github.com//pull/206919 (I assume by mistake)\r\nthis waitFor is needed for testing passing with React@18, see\r\nhttps://github.com//pull/208339/files#diff-bf9743a8d3aa8ed102d36f9117fb14e455efa23df7da28a4ac44b7efa270899a\r\n\r\n\r\n```\r\nREACT_18=true yarn test:jest x-pack/solutions/security/plugins/session_view/public/components/tty_player/hooks.test.tsx\r\n```","sha":"fc179a8d47b7a7ab622dfce519154175b1821869"}}]}] BACKPORT--> Co-authored-by: Anton Dosov <[email protected]>
|
@elasticmachine merge upstream |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 28, 2025
…ch using expected exception item fields (elastic#208396) ## Summary fix elastic#208339 (comment) - [ ] [[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-264a-4056-8026-2be65f9e16b9) [[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-264a-4056-8026-2be65f9e16b9/artifacts/0194a7ad-2ab6-40c2-a11c-685683bbb663) Jest Integration Tests / When on the host isolation exceptions page should search using expected exception item fields Fix the test so it passes with React@18 ``` REACT_18=true node scripts/jest --config=x-pack/solutions/security/plugins/security_solution/jest.integration.config.js /x-pack/solutions/security/plugins/security_solution/public/management/pages/host_isolation_exceptions/view/integration_tests/host_isolation_exceptions_list.test.tsx ``` We already saw a very similar timeout failure here: https://github.com/elastic/kibana/pull/207195/files#r1922454027 (cherry picked from commit 8f10ac2)
kibanamachine
added a commit
that referenced
this pull request
Jan 28, 2025
…d search using expected exception item fields (#208396) (#208574) # Backport This will backport the following commits from `main` to `8.x`: - [[React@18] fix When on the host isolation exceptions page should search using expected exception item fields (#208396)](#208396) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-28T16:32:02Z","message":"[React@18] fix When on the host isolation exceptions page should search using expected exception item fields (#208396)\n\n## Summary\r\n\r\nfix\r\nhttps://github.com//pull/208339#issuecomment-2615621371\r\n\r\n- [ ]\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-264a-4056-8026-2be65f9e16b9)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-264a-4056-8026-2be65f9e16b9/artifacts/0194a7ad-2ab6-40c2-a11c-685683bbb663)\r\nJest Integration Tests / When on the host isolation exceptions page\r\nshould search using expected exception item fields\r\n\r\n\r\nFix the test so it passes with React@18\r\n\r\n\r\n```\r\nREACT_18=true node scripts/jest --config=x-pack/solutions/security/plugins/security_solution/jest.integration.config.js /x-pack/solutions/security/plugins/security_solution/public/management/pages/host_isolation_exceptions/view/integration_tests/host_isolation_exceptions_list.test.tsx\r\n```\r\n\r\n\r\nWe already saw a very similar timeout failure here:\r\nhttps://github.com//pull/207195/files#r1922454027","sha":"8f10ac2163de398e8d22a0d14a5cbe99ccc951fa","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","React@18"],"title":"[React@18] fix When on the host isolation exceptions page should search using expected exception item fields","number":208396,"url":"https://github.com/elastic/kibana/pull/208396","mergeCommit":{"message":"[React@18] fix When on the host isolation exceptions page should search using expected exception item fields (#208396)\n\n## Summary\r\n\r\nfix\r\nhttps://github.com//pull/208339#issuecomment-2615621371\r\n\r\n- [ ]\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-264a-4056-8026-2be65f9e16b9)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-264a-4056-8026-2be65f9e16b9/artifacts/0194a7ad-2ab6-40c2-a11c-685683bbb663)\r\nJest Integration Tests / When on the host isolation exceptions page\r\nshould search using expected exception item fields\r\n\r\n\r\nFix the test so it passes with React@18\r\n\r\n\r\n```\r\nREACT_18=true node scripts/jest --config=x-pack/solutions/security/plugins/security_solution/jest.integration.config.js /x-pack/solutions/security/plugins/security_solution/public/management/pages/host_isolation_exceptions/view/integration_tests/host_isolation_exceptions_list.test.tsx\r\n```\r\n\r\n\r\nWe already saw a very similar timeout failure here:\r\nhttps://github.com//pull/207195/files#r1922454027","sha":"8f10ac2163de398e8d22a0d14a5cbe99ccc951fa"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208396","number":208396,"mergeCommit":{"message":"[React@18] fix When on the host isolation exceptions page should search using expected exception item fields (#208396)\n\n## Summary\r\n\r\nfix\r\nhttps://github.com//pull/208339#issuecomment-2615621371\r\n\r\n- [ ]\r\n[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/270417#0194a78a-264a-4056-8026-2be65f9e16b9)\r\n[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/270417/jobs/0194a78a-264a-4056-8026-2be65f9e16b9/artifacts/0194a7ad-2ab6-40c2-a11c-685683bbb663)\r\nJest Integration Tests / When on the host isolation exceptions page\r\nshould search using expected exception item fields\r\n\r\n\r\nFix the test so it passes with React@18\r\n\r\n\r\n```\r\nREACT_18=true node scripts/jest --config=x-pack/solutions/security/plugins/security_solution/jest.integration.config.js /x-pack/solutions/security/plugins/security_solution/public/management/pages/host_isolation_exceptions/view/integration_tests/host_isolation_exceptions_list.test.tsx\r\n```\r\n\r\n\r\nWe already saw a very similar timeout failure here:\r\nhttps://github.com//pull/207195/files#r1922454027","sha":"8f10ac2163de398e8d22a0d14a5cbe99ccc951fa"}}]}] BACKPORT--> Co-authored-by: Anton Dosov <[email protected]>
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.