Add warnings to upgrade assistant for search sessions #206998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
lukasolson
added
v9.0.0
Team:DataDiscovery
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
jughosta
reviewed
Jan 21, 2025
src/platform/plugins/shared/data/server/deprecations/search_sessions.ts
Outdated
Show resolved
Hide resolved
src/platform/plugins/shared/data/server/deprecations/search_sessions.ts
Outdated
Show resolved
Hide resolved
src/platform/plugins/shared/data/server/deprecations/search_sessions.ts
Outdated
Show resolved
Hide resolved
src/platform/plugins/shared/data/server/deprecations/search_sessions.ts
Outdated
Show resolved
Hide resolved
jughosta
approved these changes
Jan 28, 2025
src/platform/plugins/shared/data/server/deprecations/search_sessions.ts
Outdated
Show resolved
Hide resolved
Wouldn't this be backported to 8.x so it shows up before you upgrade to 9.0? |
…ssions.ts Co-authored-by: Julia Rechkunova <[email protected]>
|
If we are planning to have this warning in 8.x then I think the wording needs to be slightly updated for 8.x branch: instead of |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @lukasolson |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/13020528425 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Jan 29, 2025
## Summary Part of elastic#203925. Resolves elastic#205813. Adds warning messages to the upgrade assistant if a cluster has unexpired search sessions, since the feature is being disabled by default and will have to be explicitly re-enabled to manage the sessions. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Julia Rechkunova <[email protected]> (cherry picked from commit b998946) # Conflicts: # docs/upgrade-notes.asciidoc
lukasolson
added a commit
that referenced
this pull request
Jan 30, 2025
…#208833) # Backport This will backport the following commits from `main` to `8.x`: - [Add warnings to upgrade assistant for search sessions (#206998)](#206998) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Lukas Olson","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-28T22:13:53Z","message":"Add warnings to upgrade assistant for search sessions (#206998)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/203925.\r\nResolves https://github.com/elastic/kibana/issues/205813.\r\n\r\nAdds warning messages to the upgrade assistant if a cluster has\r\nunexpired search sessions, since the feature is being disabled by\r\ndefault and will have to be explicitly re-enabled to manage the\r\nsessions.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Julia Rechkunova <[email protected]>","sha":"b998946003273245f9ea851ad60347c9f83c593a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","Feature:Search Sessions","backport:prev-minor"],"title":"Add warnings to upgrade assistant for search sessions","number":206998,"url":"https://github.com/elastic/kibana/pull/206998","mergeCommit":{"message":"Add warnings to upgrade assistant for search sessions (#206998)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/203925.\r\nResolves https://github.com/elastic/kibana/issues/205813.\r\n\r\nAdds warning messages to the upgrade assistant if a cluster has\r\nunexpired search sessions, since the feature is being disabled by\r\ndefault and will have to be explicitly re-enabled to manage the\r\nsessions.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Julia Rechkunova <[email protected]>","sha":"b998946003273245f9ea851ad60347c9f83c593a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206998","number":206998,"mergeCommit":{"message":"Add warnings to upgrade assistant for search sessions (#206998)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/203925.\r\nResolves https://github.com/elastic/kibana/issues/205813.\r\n\r\nAdds warning messages to the upgrade assistant if a cluster has\r\nunexpired search sessions, since the feature is being disabled by\r\ndefault and will have to be explicitly re-enabled to manage the\r\nsessions.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Julia Rechkunova <[email protected]>","sha":"b998946003273245f9ea851ad60347c9f83c593a"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #203925.
Resolves #205813.
Adds warning messages to the upgrade assistant if a cluster has unexpired search sessions, since the feature is being disabled by default and will have to be explicitly re-enabled to manage the sessions.