[dashboard] fix Chrome no longer hidden for reports #206988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
release_note:fix
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
I was able to reproduce the bug by opening a Dashboard in a new tab with the fullscreen mode param set. I think we need to update the /*
* Manage chrome visibility when dashboard is in print mode.
*/
useEffect(() => {
if (!embedSettings && viewMode === 'print') coreServices.chrome.setIsVisible(false);
}, [embedSettings, viewMode]); |
💚 Build Succeeded
Metrics [docs]Async chunks
|
|
@elasticmachine merge upstream |
ThomThomson
approved these changes
Jan 20, 2025
|
Starting backport for target branches: 8.16, 8.17, 8.x https://github.com/elastic/kibana/actions/runs/12875599051 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 20, 2025
Fixes elastic#205794 elastic#196275 removed `setIsVisible` because https://github.com/elastic/kibana/pull/196275/files#r1811034594. I could not reproduce the top nav disappearing and reappearing issue. --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 583b852)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 20, 2025
Fixes elastic#205794 elastic#196275 removed `setIsVisible` because https://github.com/elastic/kibana/pull/196275/files#r1811034594. I could not reproduce the top nav disappearing and reappearing issue. --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 583b852)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 20, 2025
Fixes elastic#205794 elastic#196275 removed `setIsVisible` because https://github.com/elastic/kibana/pull/196275/files#r1811034594. I could not reproduce the top nav disappearing and reappearing issue. --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 583b852)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 20, 2025
…207266) # Backport This will backport the following commits from `main` to `8.x`: - [[dashboard] fix Chrome no longer hidden for reports (#206988)](#206988) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-20T21:01:13Z","message":"[dashboard] fix Chrome no longer hidden for reports (#206988)\n\nFixes https://github.com/elastic/kibana/issues/205794\r\n\r\nhttps://github.com/elastic/kibana/pull/196275 removed `setIsVisible`\r\nbecause https://github.com/elastic/kibana/pull/196275/files#r1811034594.\r\nI could not reproduce the top nav disappearing and reappearing issue.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"583b8522510102c15b175f4aff772484b689869f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","v9.0.0","backport:version","v8.18.0","v8.16.4","v8.17.2"],"title":"[dashboard] fix Chrome no longer hidden for reports","number":206988,"url":"https://github.com/elastic/kibana/pull/206988","mergeCommit":{"message":"[dashboard] fix Chrome no longer hidden for reports (#206988)\n\nFixes https://github.com/elastic/kibana/issues/205794\r\n\r\nhttps://github.com/elastic/kibana/pull/196275 removed `setIsVisible`\r\nbecause https://github.com/elastic/kibana/pull/196275/files#r1811034594.\r\nI could not reproduce the top nav disappearing and reappearing issue.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"583b8522510102c15b175f4aff772484b689869f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206988","number":206988,"mergeCommit":{"message":"[dashboard] fix Chrome no longer hidden for reports (#206988)\n\nFixes https://github.com/elastic/kibana/issues/205794\r\n\r\nhttps://github.com/elastic/kibana/pull/196275 removed `setIsVisible`\r\nbecause https://github.com/elastic/kibana/pull/196275/files#r1811034594.\r\nI could not reproduce the top nav disappearing and reappearing issue.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"583b8522510102c15b175f4aff772484b689869f"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jan 20, 2025
…207264) # Backport This will backport the following commits from `main` to `8.16`: - [[dashboard] fix Chrome no longer hidden for reports (#206988)](#206988) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-20T21:01:13Z","message":"[dashboard] fix Chrome no longer hidden for reports (#206988)\n\nFixes https://github.com/elastic/kibana/issues/205794\r\n\r\nhttps://github.com/elastic/kibana/pull/196275 removed `setIsVisible`\r\nbecause https://github.com/elastic/kibana/pull/196275/files#r1811034594.\r\nI could not reproduce the top nav disappearing and reappearing issue.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"583b8522510102c15b175f4aff772484b689869f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","v9.0.0","backport:version","v8.18.0","v8.16.4","v8.17.2"],"title":"[dashboard] fix Chrome no longer hidden for reports","number":206988,"url":"https://github.com/elastic/kibana/pull/206988","mergeCommit":{"message":"[dashboard] fix Chrome no longer hidden for reports (#206988)\n\nFixes https://github.com/elastic/kibana/issues/205794\r\n\r\nhttps://github.com/elastic/kibana/pull/196275 removed `setIsVisible`\r\nbecause https://github.com/elastic/kibana/pull/196275/files#r1811034594.\r\nI could not reproduce the top nav disappearing and reappearing issue.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"583b8522510102c15b175f4aff772484b689869f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206988","number":206988,"mergeCommit":{"message":"[dashboard] fix Chrome no longer hidden for reports (#206988)\n\nFixes https://github.com/elastic/kibana/issues/205794\r\n\r\nhttps://github.com/elastic/kibana/pull/196275 removed `setIsVisible`\r\nbecause https://github.com/elastic/kibana/pull/196275/files#r1811034594.\r\nI could not reproduce the top nav disappearing and reappearing issue.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"583b8522510102c15b175f4aff772484b689869f"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jan 20, 2025
…207265) # Backport This will backport the following commits from `main` to `8.17`: - [[dashboard] fix Chrome no longer hidden for reports (#206988)](#206988) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-20T21:01:13Z","message":"[dashboard] fix Chrome no longer hidden for reports (#206988)\n\nFixes https://github.com/elastic/kibana/issues/205794\r\n\r\nhttps://github.com/elastic/kibana/pull/196275 removed `setIsVisible`\r\nbecause https://github.com/elastic/kibana/pull/196275/files#r1811034594.\r\nI could not reproduce the top nav disappearing and reappearing issue.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"583b8522510102c15b175f4aff772484b689869f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","v9.0.0","backport:version","v8.18.0","v8.16.4","v8.17.2"],"title":"[dashboard] fix Chrome no longer hidden for reports","number":206988,"url":"https://github.com/elastic/kibana/pull/206988","mergeCommit":{"message":"[dashboard] fix Chrome no longer hidden for reports (#206988)\n\nFixes https://github.com/elastic/kibana/issues/205794\r\n\r\nhttps://github.com/elastic/kibana/pull/196275 removed `setIsVisible`\r\nbecause https://github.com/elastic/kibana/pull/196275/files#r1811034594.\r\nI could not reproduce the top nav disappearing and reappearing issue.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"583b8522510102c15b175f4aff772484b689869f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206988","number":206988,"mergeCommit":{"message":"[dashboard] fix Chrome no longer hidden for reports (#206988)\n\nFixes https://github.com/elastic/kibana/issues/205794\r\n\r\nhttps://github.com/elastic/kibana/pull/196275 removed `setIsVisible`\r\nbecause https://github.com/elastic/kibana/pull/196275/files#r1811034594.\r\nI could not reproduce the top nav disappearing and reappearing issue.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"583b8522510102c15b175f4aff772484b689869f"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Jan 21, 2025
Fixes elastic#205794 elastic#196275 removed `setIsVisible` because https://github.com/elastic/kibana/pull/196275/files#r1811034594. I could not reproduce the top nav disappearing and reappearing issue. --------- Co-authored-by: Elastic Machine <[email protected]>
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
Fixes elastic#205794 elastic#196275 removed `setIsVisible` because https://github.com/elastic/kibana/pull/196275/files#r1811034594. I could not reproduce the top nav disappearing and reappearing issue. --------- Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #205794
#196275 removed
setIsVisiblebecause https://github.com/elastic/kibana/pull/196275/files#r1811034594. I could not reproduce the top nav disappearing and reappearing issue.