fix flaky input control chained test #20642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
|
passed first time with 25 runs jenkins, test this |
💚 Build Succeeded |
|
Jenkins, test this |
💚 Build Succeeded |
|
Jenkins, test this |
💚 Build Succeeded |
|
Jenkins, test this |
💚 Build Succeeded |
|
Jenkins, test this |
💚 Build Succeeded |
|
Jenkins, test this |
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
timroes
approved these changes
Jul 17, 2018
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jul 17, 2018
* add check that combobox was successfully cleared * run test 25 times * checkin the correct files this time * re-enable skipped test * remove extra test loaders
nreese
added a commit
that referenced
this pull request
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20633
The test was failing because some times,
clearComboBoxdid not clear the combo box. This caused the assertion statement to fail. This PR wraps the clear in a retry that will attempt to clear again if the the previous attempts were not successful.