disable flaky input controls vis test #20637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nreese
commented
Jul 10, 2018
nreese
commented
|
Issue tracked here: #20633 |
| @@ -286,7 +286,7 @@ export default function ({ getService, getPageObjects }) { | |||
| await testSubjects.click('inputControlCancelBtn'); | |||
| }); | |||
|
|
|||
| it('should clear child control dropdown when parent control filter pill removed', async () => { | |||
| it.skip('should clear child control dropdown when parent control filter pill removed', async () => { | |||
There was a problem hiding this comment.
why skipping this one too? Noticed it also being flaky? Or doesn't work without the context of the top one?
There was a problem hiding this comment.
I was thinking it was dependent on the test above but that is not the case. I will remove the skip for that test
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jul 10, 2018
* disable flaky input controls vis test * only skip flaky test
nreese
added a commit
that referenced
this pull request
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.