Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.17] [ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726) #205867

Merged
merged 1 commit into from
Jan 8, 2025
Merged

[7.17] [ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (#205726) #205867

merged 1 commit into from
Jan 8, 2025

Conversation

Bluefinger
Copy link
Contributor

Backport

This will backport the following commits from main to 7.17:

Questions ?

Please refer to the Backport tool documentation

@Bluefinger
[ML][APM] Fix Cytoscape listener typing, Update Cytoscape versions (e…
b0eda0f 
…lastic#205726)

## Summary

Updates Cytoscape to newer versions, requiring one change with some
`removeListener` usage no longer being valid typing.

Supersedes elastic#205444

## How to test

- Passes CI with no type errors or failed CI jobs for ML
- Job Map or wherever cytoscape is being used on ML doesn't leak event
listeners.
- Usages in APM also do not break.
@Bluefinger Bluefinger enabled auto-merge (squash) January 8, 2025 11:01
@Bluefinger Bluefinger mentioned this pull request Jan 8, 2025
Merged
@Bluefinger Bluefinger merged commit 828e49d into elastic:7.17 Jan 8, 2025
90 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1028 1025 -3
ml 1598 1595 -3
total -6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.4MB 2.4MB +34.5KB
ml 3.3MB 3.4MB +34.6KB
total +69.1KB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miloszmarcinkowski miloszmarcinkowski miloszmarcinkowski approved these changes

@rmyz rmyz rmyz approved these changes

@jennypavlova jennypavlova jennypavlova approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Bluefinger @elasticmachine @jennypavlova @rmyz @miloszmarcinkowski