-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase prettier line width to 100 #20535
Conversation
Our style guide says 120 js_style_guide |
💔 Build Failed |
💚 Build Succeeded |
@markov00 I would understand Since people seem to like and upvote the 100 chars width, I would also change the styleguide accordingly, to be a bite more clear and not giving us a range. Since we also enforce the line width in the reverse way, i.e. you cannot split up a line if it would fit into that setting, I would rather limit it to the 100 (that's somewhere in the middle of 80 and 120), since I think 120 char lines could tend to be rather long as a "must" have. |
💚 Build Succeeded |
I'm neither here nor there on 80 vs 100, could go either way, but
I'm +1 on picking a width and removing the ambiguity. |
i agree with @stacey-gammon i am also ok with updating only the docs |
@stacey-gammon @ppisljar I already updated the docs, to be less ambiguous about the length, and clearly set it to 100 with this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not happy with how prettier tries to cram as much code on a line as possible, but I'm glad we're picking an explicit line length!
💚 Build Succeeded |
* Increase prettier line width to 100 * Fix packages JS prettier * Change style guide to 100 width * Fix line-width in latest master changes
In this PR I increase the max line width in prettier to 100. Since we enforce the prettier styling for TypeScript I wanted to put this up for discussion if 80 (which it was right now) is really reasonable. You can also check the auto fixes in this PR to get a feeling how 80 chars vs 100 chars will look like.
Please feel free to vote up/down on this PR to switch to 100 chars line width (and in case you also vote up, feel free to leave a review).