Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Streams] Schema Editor isWiredStream > isWiredReadStream #205251

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

Kerry350
Copy link
Contributor

@Kerry350 Kerry350 commented Dec 30, 2024

Summary

Small fix to the Schema Editor page after the changes in #204671.

(Without this mapped fields won't be displayed as we use a read stream definition).

@Kerry350 Kerry350 added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:version Backport to applied version labels v8.18.0 Feature:Streams This is the label for the Streams Project labels Dec 30, 2024
@Kerry350 Kerry350 self-assigned this Dec 30, 2024
@Kerry350 Kerry350 requested a review from a team as a code owner December 30, 2024 12:33
Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found the same issues while working on my PR for the enrichment, thanks for the fix!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 182.3KB 182.3KB -3.0B

cc @Kerry350

@Kerry350 Kerry350 merged commit 8cc2f2b into elastic:main Dec 30, 2024
19 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12547838339

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 30, 2024
…5251)

## Summary

Small fix to the Schema Editor page after the changes in
elastic#204671.

(Without this mapped fields won't be displayed as we use a read stream
definition).

(cherry picked from commit 8cc2f2b)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 30, 2024
…205251) (#205266)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Streams] Schema Editor isWiredStream > isWiredReadStream
(#205251)](#205251)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kerry
Gallagher","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-30T14:24:19Z","message":"[Streams]
Schema Editor isWiredStream > isWiredReadStream (#205251)\n\n##
Summary\r\n\r\nSmall fix to the Schema Editor page after the changes
in\r\nhttps://github.com//pull/204671.\r\n\r\n(Without
this mapped fields won't be displayed as we use a read
stream\r\ndefinition).","sha":"8cc2f2b9c8c463feaa87f77a05e46a3f75f10fb7","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.18.0","Feature:Streams"],"title":"[Streams]
Schema Editor isWiredStream >
isWiredReadStream","number":205251,"url":"https://github.com/elastic/kibana/pull/205251","mergeCommit":{"message":"[Streams]
Schema Editor isWiredStream > isWiredReadStream (#205251)\n\n##
Summary\r\n\r\nSmall fix to the Schema Editor page after the changes
in\r\nhttps://github.com//pull/204671.\r\n\r\n(Without
this mapped fields won't be displayed as we use a read
stream\r\ndefinition).","sha":"8cc2f2b9c8c463feaa87f77a05e46a3f75f10fb7"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205251","number":205251,"mergeCommit":{"message":"[Streams]
Schema Editor isWiredStream > isWiredReadStream (#205251)\n\n##
Summary\r\n\r\nSmall fix to the Schema Editor page after the changes
in\r\nhttps://github.com//pull/204671.\r\n\r\n(Without
this mapped fields won't be displayed as we use a read
stream\r\ndefinition).","sha":"8cc2f2b9c8c463feaa87f77a05e46a3f75f10fb7"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Kerry Gallagher <[email protected]>
stratoula pushed a commit to stratoula/kibana that referenced this pull request Jan 2, 2025
…5251)

## Summary

Small fix to the Schema Editor page after the changes in
elastic#204671.

(Without this mapped fields won't be displayed as we use a read stream
definition).
benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
…5251)

## Summary

Small fix to the Schema Editor page after the changes in
elastic#204671.

(Without this mapped fields won't be displayed as we use a read stream
definition).
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Jan 2, 2025
…5251)

## Summary

Small fix to the Schema Editor page after the changes in
elastic#204671.

(Without this mapped fields won't be displayed as we use a read stream
definition).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels Feature:Streams This is the label for the Streams Project release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants