Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update visualize development docs #20507

Merged
merged 2 commits into from
Jul 9, 2018

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Jul 6, 2018

update visualize development docs

  • embedding using visualization directive is removed

@ppisljar ppisljar added review Team:Docs Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v6.4.0 labels Jul 6, 2018
@ppisljar ppisljar requested a review from timroes July 6, 2018 05:19
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

-----------

<visualization> will trigger `renderComplete` event on the element once it's done rendering.
We recommend *not* to use the internal `<visualize>` Angular directive directly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove that line with the refactoring of visualize.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@ppisljar ppisljar merged commit dfeb947 into elastic:master Jul 9, 2018
ppisljar added a commit to ppisljar/kibana that referenced this pull request Jul 9, 2018
@ppisljar ppisljar deleted the fix/cleanDocsVisualize branch July 9, 2018 20:39
@ppisljar ppisljar restored the fix/cleanDocsVisualize branch September 26, 2018 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review Team:Docs v6.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants