Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [embeddable] remove legacy embeddable types (#204832) #204952

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Dec 19, 2024

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@nreese nreese enabled auto-merge (squash) December 19, 2024 14:21
@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Dec 19, 2024
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #12 / InfraOps App Metrics UI Node Details #Asset Type: host Processes Tab should render processes tab and with Total Value summary

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
embeddable 141 131 -10

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
embeddable 289 266 -23

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
embeddable 1 0 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 632.7KB 632.7KB +13.0B
securitySolution 18.5MB 18.5MB +342.0B
total +355.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
embeddable 4 3 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 49.1KB 46.8KB -2.3KB
Unknown metric groups

API count

id before after diff
embeddable 374 339 -35

@nreese nreese merged commit 8a46374 into elastic:8.x Dec 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Feature:Embedding Embedding content via iFrame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants