Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES body removal] @elastic/appex-qa #204878

Merged

Conversation

afharo
Copy link
Member

@afharo afharo commented Dec 19, 2024

Summary

Attempt to remove the deprecated body in the ES client.

@afharo afharo added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 19, 2024
@afharo afharo self-assigned this Dec 19, 2024
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #108 / serverless search UI Serverless Inference Management UI delete action "before each" hook for "deletes modal successfully with usage"

Metrics [docs]

✅ unchanged

cc @afharo

@afharo afharo marked this pull request as ready for review December 19, 2024 09:52
@afharo afharo requested review from a team as code owners December 19, 2024 09:52
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afharo afharo merged commit b189fe7 into elastic:main Dec 19, 2024
14 checks passed
@afharo afharo deleted the esclient/remove-deprecated-body/elastic/appex-qa branch December 19, 2024 11:06
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12411462004

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 19, 2024
## Summary

Attempt to remove the deprecated `body` in the ES client.

(cherry picked from commit b189fe7)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 19, 2024
…04878) (#204916)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES `body` removal] `@elastic/appex-qa`
(#204878)](#204878)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T11:06:42Z","message":"[ES
`body` removal] `@elastic/appex-qa` (#204878)\n\n## Summary\n\nAttempt
to remove the deprecated `body` in the ES
client.","sha":"b189fe715912ad83a37e6bb77e2084dbdc41604b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"[ES
`body` removal]
`@elastic/appex-qa`","number":204878,"url":"https://github.com/elastic/kibana/pull/204878","mergeCommit":{"message":"[ES
`body` removal] `@elastic/appex-qa` (#204878)\n\n## Summary\n\nAttempt
to remove the deprecated `body` in the ES
client.","sha":"b189fe715912ad83a37e6bb77e2084dbdc41604b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204878","number":204878,"mergeCommit":{"message":"[ES
`body` removal] `@elastic/appex-qa` (#204878)\n\n## Summary\n\nAttempt
to remove the deprecated `body` in the ES
client.","sha":"b189fe715912ad83a37e6bb77e2084dbdc41604b"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Haro <[email protected]>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
## Summary

Attempt to remove the deprecated `body` in the ES client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants