Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[embeddable] remove export of inspector-plugin types #204816

Merged
merged 4 commits into from
Dec 18, 2024
Merged

[embeddable] remove export of inspector-plugin types #204816

merged 4 commits into from
Dec 18, 2024

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Dec 18, 2024 •
edited by kibanamachine
Loading

null

@nreese
Copy link
Contributor Author

nreese commented Dec 18, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Dec 18, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Dec 18, 2024

/ci

@nreese nreese marked this pull request as ready for review December 18, 2024 20:19
@nreese nreese requested review from a team as code owners December 18, 2024 20:19
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes v9.0.0 project:embeddableRebuild backport:version Backport to applied version labels v8.18.0 labels Dec 18, 2024
@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Dec 18, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
embeddable 291 289 -2
Unknown metric groups

API count

id before after diff
embeddable 377 374 -3

History

@nreese nreese merged commit 07c85dc into elastic:main Dec 18, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12402179467

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 18, 2024
@nreese
[embeddable] remove export of inspector-plugin types (elastic#204816)
411c7bc 
(cherry picked from commit 07c85dc)
@kibanamachine kibanamachine mentioned this pull request Dec 18, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 18, 2024
@kibanamachine @nreese
[8.x] [embeddable] remove export of inspector-plugin types (#204816) (#…
e0ee319 
…204841)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[embeddable] remove export of inspector-plugin types
(#204816)](#204816)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-18T22:10:22Z","message":"[embeddable]
remove export of inspector-plugin types
(#204816)","sha":"07c85dcac9acfa34fe2b07efe3f88ca02be446b6","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Embedding","Team:Presentation","release_note:skip","v9.0.0","project:embeddableRebuild","backport:version","v8.18.0"],"title":"[embeddable]
remove export of inspector-plugin
types","number":204816,"url":"https://github.com/elastic/kibana/pull/204816","mergeCommit":{"message":"[embeddable]
remove export of inspector-plugin types
(#204816)","sha":"07c85dcac9acfa34fe2b07efe3f88ca02be446b6"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204816","number":204816,"mergeCommit":{"message":"[embeddable]
remove export of inspector-plugin types
(#204816)","sha":"07c85dcac9acfa34fe2b07efe3f88ca02be446b6"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <[email protected]>
@nreese nreese mentioned this pull request Dec 19, 2024
Merged
Ikuni17 pushed a commit that referenced this pull request Dec 19, 2024
@nreese
[visualizations] fix eslint error (#204972)
5df5e4f 
#204816 merged into main
then #204832 merged into main. The
combination of these merges resulted in an eslint error in main.
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
@nreese @JoseLuisGJ
[embeddable] remove export of inspector-plugin types (elastic#204816)
4660c09
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
@nreese @JoseLuisGJ
[visualizations] fix eslint error (elastic#204972)
acacded 
elastic#204816 merged into main
then elastic#204832 merged into main. The
combination of these merges resulted in an eslint error in main.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

@markov00 markov00 markov00 approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels Feature:Embedding Embedding content via iFrame project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nreese @elasticmachine @kibanamachine @markov00 @ThomThomson