Add @kbn/react-kibana-context-* packages to shared bundle
#204794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosant
changed the title
@kbn/react-kibana-*-contextpackages to shared bundle
Dosant
changed the title
@kbn/react-kibana-*-contextpackages to shared bundle@kbn/react-kibana-context-*packages to shared bundle
Dosant
changed the title
@kbn/react-kibana-context-*packages to shared bundle@kbn/react-kibana-context-* packages to shared bundle
Dosant
added
release_note:skip
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
Ikuni17
approved these changes
Dec 19, 2024
clintandrewhall
approved these changes
Dec 27, 2024
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
History
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12545318115 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Dec 30, 2024
…204794) ## Summary Part of elastic#204761 These packages are meant to be used by each render tree. `react-kibana-context-theme` was already part of a shared bundle and most of them were already part of Bazel, let's add all of them for consistency and to reduce bundle size (cherry picked from commit 39d8d7d) # Conflicts: # packages/kbn-ui-shared-deps-src/BUILD.bazel # packages/kbn-ui-shared-deps-src/src/definitions.js # packages/kbn-ui-shared-deps-src/src/entry.js
Dosant
added a commit
that referenced
this pull request
Dec 30, 2024
…04794) (#205259) # Backport This will backport the following commits from `main` to `8.x`: - [Add `@kbn/react-kibana-context-*` packages to shared bundle (#204794)](#204794) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-30T10:33:20Z","message":"Add `@kbn/react-kibana-context-*` packages to shared bundle (#204794)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/204761\r\n\r\nThese packages are meant to be used by each render tree.\r\n`react-kibana-context-theme` was already part of a shared bundle and\r\nmost of them were already part of Bazel, let's add all of them for\r\nconsistency and to reduce bundle size","sha":"39d8d7dc3fd4140cf3f7477cb7343d21ea113e48","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor"],"number":204794,"url":"https://github.com/elastic/kibana/pull/204794","mergeCommit":{"message":"Add `@kbn/react-kibana-context-*` packages to shared bundle (#204794)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/204761\r\n\r\nThese packages are meant to be used by each render tree.\r\n`react-kibana-context-theme` was already part of a shared bundle and\r\nmost of them were already part of Bazel, let's add all of them for\r\nconsistency and to reduce bundle size","sha":"39d8d7dc3fd4140cf3f7477cb7343d21ea113e48"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204794","number":204794,"mergeCommit":{"message":"Add `@kbn/react-kibana-context-*` packages to shared bundle (#204794)\n\n## Summary\r\n\r\nPart of https://github.com/elastic/kibana/issues/204761\r\n\r\nThese packages are meant to be used by each render tree.\r\n`react-kibana-context-theme` was already part of a shared bundle and\r\nmost of them were already part of Bazel, let's add all of them for\r\nconsistency and to reduce bundle size","sha":"39d8d7dc3fd4140cf3f7477cb7343d21ea113e48"}}]}] BACKPORT-->
stratoula
pushed a commit
to stratoula/kibana
that referenced
this pull request
Jan 2, 2025
…204794) ## Summary Part of elastic#204761 These packages are meant to be used by each render tree. `react-kibana-context-theme` was already part of a shared bundle and most of them were already part of Bazel, let's add all of them for consistency and to reduce bundle size
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Jan 2, 2025
…204794) ## Summary Part of elastic#204761 These packages are meant to be used by each render tree. `react-kibana-context-theme` was already part of a shared bundle and most of them were already part of Bazel, let's add all of them for consistency and to reduce bundle size
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Jan 2, 2025
…204794) ## Summary Part of elastic#204761 These packages are meant to be used by each render tree. `react-kibana-context-theme` was already part of a shared bundle and most of them were already part of Bazel, let's add all of them for consistency and to reduce bundle size
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
…204794) ## Summary Part of elastic#204761 These packages are meant to be used by each render tree. `react-kibana-context-theme` was already part of a shared bundle and most of them were already part of Bazel, let's add all of them for consistency and to reduce bundle size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #204761
These packages are meant to be used by each render tree.
react-kibana-context-themewas already part of a shared bundle and most of them were already part of Bazel, let's add all of them for consistency and to reduce bundle sizecc @clintandrewhall @tkajtoch