Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional test for create a logdb index #204788

Merged
merged 8 commits into from
Dec 30, 2024
Merged

Functional test for create a logdb index #204788

merged 8 commits into from
Dec 30, 2024

Conversation

SoniaSanzV
Copy link
Contributor

@SoniaSanzV SoniaSanzV commented Dec 18, 2024 •
edited by kibanamachine
Loading

Part of #203716

Summary

  • Functional test for verifying that users can create indices using the “logsdb” index mode via the Kibana interface (Stateful and serverless).
  • Functional test for verifying that users can upgrade a logs data stream that is using a “standard” index mode to a data stream using “logsdb” index mode. (Stateful and serverless).
  • Functional test for verifying that users can downgrade a data stream that is using a “logsdb” index mode to a data stream using “standard” index mode. (Stateful and serverless).
  • Functional test for verifying that users can upgrade a data stream that is using a “time series” index mode to a data stream using “logsdb” index mode. (Stateful and serverless).
  • Functional test for verifying that users can downgrade a data stream that is using a “logsdb” index mode to a data stream using “time series” index mode. (Stateful and serverless).

The rollover operation has not been tested since is not expected to happen automatically. See this comment.

@SoniaSanzV SoniaSanzV added Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 18, 2024
@SoniaSanzV SoniaSanzV self-assigned this Dec 18, 2024
@SoniaSanzV SoniaSanzV requested a review from a team as a code owner December 18, 2024 15:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@SoniaSanzV SoniaSanzV mentioned this pull request Dec 18, 2024
Open
12 tasks
@SoniaSanzV SoniaSanzV marked this pull request as draft December 19, 2024 09:47
@SoniaSanzV SoniaSanzV marked this pull request as ready for review December 19, 2024 12:52
mattkime
mattkime reviewed Dec 30, 2024
View reviewed changes
x-pack/test/functional/apps/index_management/data_streams_tab/data_streams_tab.ts Outdated
@@ -132,6 +132,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await es.indices.deleteIndexTemplate({
name: `logsdb_index_template`,
});
await browser.refresh();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to avoid the browser refreshes? I'm sure they're rather slow. Is there a refresh button? Or is it possible to navigate away and back?

mattkime
mattkime reviewed Dec 30, 2024
View reviewed changes
x-pack/test/functional/apps/index_management/data_streams_tab/data_streams_tab.ts Outdated
await testSubjects.click('nextButton');
await testSubjects.click('nextButton');

await verifyModeHasBeenChanged('LogsDB');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using strings for the index type, it would be nice to define the strings in one place, perhaps using an enum.

mattkime
mattkime approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of rather minor suggestions but I'll leave it up to you whether they're implemented. Nice work, thanks!

@mattkime
Copy link
Contributor

The rollover operation has not been tested since is not expected to happen automatically.

Would it make sense to manually trigger it?

@SoniaSanzV
Copy link
Contributor Author

The rollover operation has not been tested since is not expected to happen automatically.

Would it make sense to manually trigger it?

Since is a different flow, I won't do it here. I'll add it to the main issue to find out what Salvatore and Elena think about it

@SoniaSanzV SoniaSanzV enabled auto-merge (squash) December 30, 2024 10:10
@SoniaSanzV SoniaSanzV merged commit 34341e5 into elastic:main Dec 30, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12549945082

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 702.8KB 703.0KB +161.0B

History

cc @SoniaSanzV

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 30, 2024
@SoniaSanzV
Functional test for create a logdb index (elastic#204788)
850ddb2 
Part of elastic#203716
## Summary

* Functional test for verifying that users can create indices using the
“logsdb” index mode via the Kibana interface (Stateful and serverless).
* Functional test for verifying that users can upgrade a logs data
stream that is using a “standard” index mode to a data stream using
“logsdb” index mode. (Stateful and serverless).
* Functional test for verifying that users can downgrade a data stream
that is using a “logsdb” index mode to a data stream using “standard”
index mode. (Stateful and serverless).
* Functional test for verifying that users can upgrade a data stream
that is using a “time series” index mode to a data stream using “logsdb”
index mode. (Stateful and serverless).
* Functional test for verifying that users can downgrade a data stream
that is using a “logsdb” index mode to a data stream using “time series”
index mode. (Stateful and serverless).

The rollover operation has not been tested since is not expected to
happen automatically. See [this
comment](elastic#203716 (comment)).

(cherry picked from commit 34341e5)
@kibanamachine kibanamachine mentioned this pull request Dec 30, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 30, 2024
@kibanamachine @SoniaSanzV
[8.x] Functional test for create a logdb index (#204788) (#205283)
74d0869 
# Backport

This will backport the following commits from `main` to `8.x`:
- [Functional test for create a logdb index
(#204788)](#204788)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sonia Sanz
Vivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-30T17:39:49Z","message":"Functional
test for create a logdb index (#204788)\n\nPart of
https://github.com/elastic/kibana/issues/203716\n## Summary\n\n*
Functional test for verifying that users can create indices using
the\n“logsdb” index mode via the Kibana interface (Stateful and
serverless).\n* Functional test for verifying that users can upgrade a
logs data\nstream that is using a “standard” index mode to a data stream
using\n“logsdb” index mode. (Stateful and serverless).\n* Functional
test for verifying that users can downgrade a data stream\nthat is using
a “logsdb” index mode to a data stream using “standard”\nindex mode.
(Stateful and serverless).\n* Functional test for verifying that users
can upgrade a data stream\nthat is using a “time series” index mode to a
data stream using “logsdb”\nindex mode. (Stateful and serverless).\n*
Functional test for verifying that users can downgrade a data
stream\nthat is using a “logsdb” index mode to a data stream using “time
series”\nindex mode. (Stateful and serverless).\n\nThe rollover
operation has not been tested since is not expected to\nhappen
automatically. See
[this\ncomment](https://github.com/elastic/kibana/issues/203716#issuecomment-2554491054).","sha":"34341e58649dec80c58a31346c301e8c96d97d37","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index
Management","Team:Kibana
Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"Functional
test for create a logdb
index","number":204788,"url":"https://github.com/elastic/kibana/pull/204788","mergeCommit":{"message":"Functional
test for create a logdb index (#204788)\n\nPart of
https://github.com/elastic/kibana/issues/203716\n## Summary\n\n*
Functional test for verifying that users can create indices using
the\n“logsdb” index mode via the Kibana interface (Stateful and
serverless).\n* Functional test for verifying that users can upgrade a
logs data\nstream that is using a “standard” index mode to a data stream
using\n“logsdb” index mode. (Stateful and serverless).\n* Functional
test for verifying that users can downgrade a data stream\nthat is using
a “logsdb” index mode to a data stream using “standard”\nindex mode.
(Stateful and serverless).\n* Functional test for verifying that users
can upgrade a data stream\nthat is using a “time series” index mode to a
data stream using “logsdb”\nindex mode. (Stateful and serverless).\n*
Functional test for verifying that users can downgrade a data
stream\nthat is using a “logsdb” index mode to a data stream using “time
series”\nindex mode. (Stateful and serverless).\n\nThe rollover
operation has not been tested since is not expected to\nhappen
automatically. See
[this\ncomment](https://github.com/elastic/kibana/issues/203716#issuecomment-2554491054).","sha":"34341e58649dec80c58a31346c301e8c96d97d37"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204788","number":204788,"mergeCommit":{"message":"Functional
test for create a logdb index (#204788)\n\nPart of
https://github.com/elastic/kibana/issues/203716\n## Summary\n\n*
Functional test for verifying that users can create indices using
the\n“logsdb” index mode via the Kibana interface (Stateful and
serverless).\n* Functional test for verifying that users can upgrade a
logs data\nstream that is using a “standard” index mode to a data stream
using\n“logsdb” index mode. (Stateful and serverless).\n* Functional
test for verifying that users can downgrade a data stream\nthat is using
a “logsdb” index mode to a data stream using “standard”\nindex mode.
(Stateful and serverless).\n* Functional test for verifying that users
can upgrade a data stream\nthat is using a “time series” index mode to a
data stream using “logsdb”\nindex mode. (Stateful and serverless).\n*
Functional test for verifying that users can downgrade a data
stream\nthat is using a “logsdb” index mode to a data stream using “time
series”\nindex mode. (Stateful and serverless).\n\nThe rollover
operation has not been tested since is not expected to\nhappen
automatically. See
[this\ncomment](https://github.com/elastic/kibana/issues/203716#issuecomment-2554491054).","sha":"34341e58649dec80c58a31346c301e8c96d97d37"}}]}]
BACKPORT-->

Co-authored-by: Sonia Sanz Vivas <[email protected]>
stratoula pushed a commit to stratoula/kibana that referenced this pull request Jan 2, 2025
@SoniaSanzV @stratoula
Functional test for create a logdb index (elastic#204788)
d1c5578 
Part of elastic#203716
## Summary

* Functional test for verifying that users can create indices using the
“logsdb” index mode via the Kibana interface (Stateful and serverless).
* Functional test for verifying that users can upgrade a logs data
stream that is using a “standard” index mode to a data stream using
“logsdb” index mode. (Stateful and serverless).
* Functional test for verifying that users can downgrade a data stream
that is using a “logsdb” index mode to a data stream using “standard”
index mode. (Stateful and serverless).
* Functional test for verifying that users can upgrade a data stream
that is using a “time series” index mode to a data stream using “logsdb”
index mode. (Stateful and serverless).
* Functional test for verifying that users can downgrade a data stream
that is using a “logsdb” index mode to a data stream using “time series”
index mode. (Stateful and serverless).

The rollover operation has not been tested since is not expected to
happen automatically. See [this
comment](elastic#203716 (comment)).
benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
@SoniaSanzV @benakansara
Functional test for create a logdb index (elastic#204788)
2f2d2c1 
Part of elastic#203716
## Summary

* Functional test for verifying that users can create indices using the
“logsdb” index mode via the Kibana interface (Stateful and serverless).
* Functional test for verifying that users can upgrade a logs data
stream that is using a “standard” index mode to a data stream using
“logsdb” index mode. (Stateful and serverless).
* Functional test for verifying that users can downgrade a data stream
that is using a “logsdb” index mode to a data stream using “standard”
index mode. (Stateful and serverless).
* Functional test for verifying that users can upgrade a data stream
that is using a “time series” index mode to a data stream using “logsdb”
index mode. (Stateful and serverless).
* Functional test for verifying that users can downgrade a data stream
that is using a “logsdb” index mode to a data stream using “time series”
index mode. (Stateful and serverless).

The rollover operation has not been tested since is not expected to
happen automatically. See [this
comment](elastic#203716 (comment)).
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Jan 2, 2025
@SoniaSanzV @cqliu1
Functional test for create a logdb index (elastic#204788)
2361e4e 
Part of elastic#203716
## Summary

* Functional test for verifying that users can create indices using the
“logsdb” index mode via the Kibana interface (Stateful and serverless).
* Functional test for verifying that users can upgrade a logs data
stream that is using a “standard” index mode to a data stream using
“logsdb” index mode. (Stateful and serverless).
* Functional test for verifying that users can downgrade a data stream
that is using a “logsdb” index mode to a data stream using “standard”
index mode. (Stateful and serverless).
* Functional test for verifying that users can upgrade a data stream
that is using a “time series” index mode to a data stream using “logsdb”
index mode. (Stateful and serverless).
* Functional test for verifying that users can downgrade a data stream
that is using a “logsdb” index mode to a data stream using “time series”
index mode. (Stateful and serverless).

The rollover operation has not been tested since is not expected to
happen automatically. See [this
comment](elastic#203716 (comment)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkime mattkime mattkime approved these changes

Assignees

@SoniaSanzV SoniaSanzV

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SoniaSanzV @elasticmachine @mattkime @kibanamachine