[UA] Remove noisey warn when deleting from .tasks
#204720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloleysens
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
afharo
approved these changes
Dec 18, 2024
mattkime
approved these changes
Dec 18, 2024
|
Starting backport for target branches: 8.17, 8.x https://github.com/elastic/kibana/actions/runs/12393733694 |
💚 Build Succeeded
Metrics [docs]
cc @jloleysens |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 18, 2024
## Summary Reduce the number of `warn` logs reindexing will create due to failed attempts to delete from `.tasks`. In this PR we only log for responses that do not have status code 403 or 401. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit ff3a600)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 18, 2024
## Summary Reduce the number of `warn` logs reindexing will create due to failed attempts to delete from `.tasks`. In this PR we only log for responses that do not have status code 403 or 401. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit ff3a600)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 18, 2024
…204720) (#204758) # Backport This will backport the following commits from `main` to `8.17`: - [[UA] Remove noisey warn when deleting from `.tasks` (#204720)](#204720) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jean-Louis Leysens","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-18T13:14:57Z","message":"[UA] Remove noisey warn when deleting from `.tasks` (#204720)\n\n## Summary\r\n\r\nReduce the number of `warn` logs reindexing will create due to failed\r\nattempts to delete from `.tasks`. In this PR we only log for responses\r\nthat do not have status code 403 or 401.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"ff3a600d5eca300c769f67ce144364b5de3a2409","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","Feature:Upgrade Assistant","v9.0.0","backport:version","v8.18.0","v8.17.1"],"title":"[UA] Remove noisey warn when deleting from `.tasks`","number":204720,"url":"https://github.com/elastic/kibana/pull/204720","mergeCommit":{"message":"[UA] Remove noisey warn when deleting from `.tasks` (#204720)\n\n## Summary\r\n\r\nReduce the number of `warn` logs reindexing will create due to failed\r\nattempts to delete from `.tasks`. In this PR we only log for responses\r\nthat do not have status code 403 or 401.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"ff3a600d5eca300c769f67ce144364b5de3a2409"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204720","number":204720,"mergeCommit":{"message":"[UA] Remove noisey warn when deleting from `.tasks` (#204720)\n\n## Summary\r\n\r\nReduce the number of `warn` logs reindexing will create due to failed\r\nattempts to delete from `.tasks`. In this PR we only log for responses\r\nthat do not have status code 403 or 401.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"ff3a600d5eca300c769f67ce144364b5de3a2409"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jean-Louis Leysens <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 18, 2024
…204720) (#204759) # Backport This will backport the following commits from `main` to `8.x`: - [[UA] Remove noisey warn when deleting from `.tasks` (#204720)](#204720) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jean-Louis Leysens","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-18T13:14:57Z","message":"[UA] Remove noisey warn when deleting from `.tasks` (#204720)\n\n## Summary\r\n\r\nReduce the number of `warn` logs reindexing will create due to failed\r\nattempts to delete from `.tasks`. In this PR we only log for responses\r\nthat do not have status code 403 or 401.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"ff3a600d5eca300c769f67ce144364b5de3a2409","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","Feature:Upgrade Assistant","v9.0.0","backport:version","v8.18.0","v8.17.1"],"title":"[UA] Remove noisey warn when deleting from `.tasks`","number":204720,"url":"https://github.com/elastic/kibana/pull/204720","mergeCommit":{"message":"[UA] Remove noisey warn when deleting from `.tasks` (#204720)\n\n## Summary\r\n\r\nReduce the number of `warn` logs reindexing will create due to failed\r\nattempts to delete from `.tasks`. In this PR we only log for responses\r\nthat do not have status code 403 or 401.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"ff3a600d5eca300c769f67ce144364b5de3a2409"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204720","number":204720,"mergeCommit":{"message":"[UA] Remove noisey warn when deleting from `.tasks` (#204720)\n\n## Summary\r\n\r\nReduce the number of `warn` logs reindexing will create due to failed\r\nattempts to delete from `.tasks`. In this PR we only log for responses\r\nthat do not have status code 403 or 401.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"ff3a600d5eca300c769f67ce144364b5de3a2409"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jean-Louis Leysens <[email protected]>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
## Summary Reduce the number of `warn` logs reindexing will create due to failed attempts to delete from `.tasks`. In this PR we only log for responses that do not have status code 403 or 401. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Jan 2, 2025
## Summary Reduce the number of `warn` logs reindexing will create due to failed attempts to delete from `.tasks`. In this PR we only log for responses that do not have status code 403 or 401. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reduce the number of
warnlogs reindexing will create due to failed attempts to delete from.tasks. In this PR we only log for responses that do not have status code 403 or 401.Checklist