[ES|QL] Make sure that the commands are not overwritten #204711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
added
v9.0.0
v8.17.0
v8.18.0
backport:version
|
Pinging @elastic/kibana-esql (Team:ESQL) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Page load bundle
|
vadimkibana
approved these changes
Dec 19, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12410664387 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 19, 2024
(cherry picked from commit 76e22f7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 19, 2024
… (#204904) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Make sure that the commands are not overwritten (#204711)](#204711) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T10:16:21Z","message":"[ES|QL] Make sure that the commands are not overwritten (#204711)","sha":"76e22f7cbdd1ad1b73ad1d68ec9f0fb835bb44bd","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Feature:ES|QL","Team:ESQL","backport:version","v8.18.0"],"title":"[ES|QL] Make sure that the commands are not overwritten","number":204711,"url":"https://github.com/elastic/kibana/pull/204711","mergeCommit":{"message":"[ES|QL] Make sure that the commands are not overwritten (#204711)","sha":"76e22f7cbdd1ad1b73ad1d68ec9f0fb835bb44bd"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204711","number":204711,"mergeCommit":{"message":"[ES|QL] Make sure that the commands are not overwritten (#204711)","sha":"76e22f7cbdd1ad1b73ad1d68ec9f0fb835bb44bd"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <[email protected]>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes sure that a command in field suggestions won't get overwritten. Atm we don't have any command but we are going to have on the dashboard variables so this is a prerequisite for this