[Renovate/Core] Use prev-minor backport strategy
#204709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
release_note:skip
|
Pinging @elastic/kibana-core (Team:Core) |
|
Pinging @elastic/kibana-security (Team:Security) |
💚 Build Succeeded
History
cc @afharo |
gsoldevila
approved these changes
Dec 19, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12410433487 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
azasypkin
reviewed
Dec 19, 2024
| @@ -519,7 +519,7 @@ | |||
| ], | |||
| "labels": [ | |||
| "release_note:skip", | |||
| "backport:skip", | |||
| "backport:prev-minor", | |||
There was a problem hiding this comment.
question: Sorry, I always forget what our labels mean 🙂. If we merge something into the main branch now, which is 9.0, is prev-minor essentially equivalent to backport:skip since there is no prev-minor for 9.0?
There was a problem hiding this comment.
It's confusing, but AFAIK, prev-minor ships it to 8.x at the moment.
The labels' descriptions explain the targets to each one of them (source):
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
afharo
added a commit
that referenced
this pull request
Dec 19, 2024
…204909) # Backport This will backport the following commits from `main` to `8.x`: - [[Renovate/Core] Use `prev-minor` backport strategy (#204709)](#204709) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alejandro Fernández Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T10:02:46Z","message":"[Renovate/Core] Use `prev-minor` backport strategy (#204709)\n\n## Summary\n\nSpeaking to @azasypkin, we noticed that we are not backporting many of\nour dependency updates. These were mostly set to `backport:skip` before\nthe 9 vs. 8.x branch split. But we need it at the moment.\n\nWe'll need to revisit our backport strategy once we release 9.0.\n\n### Identify risks\n\n- [ ] Some deps like `@elastic/elasticsearch` might be bumped to 9.0 and\nshouldn't be backported. We'll update the renovate file when that\noccurs.","sha":"997884e1ba14a4e68647f13b90b7a9337c20d35a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","Team:Security","release_note:skip","dependencies","v9.0.0","backport:prev-minor"],"number":204709,"url":"https://github.com/elastic/kibana/pull/204709","mergeCommit":{"message":"[Renovate/Core] Use `prev-minor` backport strategy (#204709)\n\n## Summary\n\nSpeaking to @azasypkin, we noticed that we are not backporting many of\nour dependency updates. These were mostly set to `backport:skip` before\nthe 9 vs. 8.x branch split. But we need it at the moment.\n\nWe'll need to revisit our backport strategy once we release 9.0.\n\n### Identify risks\n\n- [ ] Some deps like `@elastic/elasticsearch` might be bumped to 9.0 and\nshouldn't be backported. We'll update the renovate file when that\noccurs.","sha":"997884e1ba14a4e68647f13b90b7a9337c20d35a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204709","number":204709,"mergeCommit":{"message":"[Renovate/Core] Use `prev-minor` backport strategy (#204709)\n\n## Summary\n\nSpeaking to @azasypkin, we noticed that we are not backporting many of\nour dependency updates. These were mostly set to `backport:skip` before\nthe 9 vs. 8.x branch split. But we need it at the moment.\n\nWe'll need to revisit our backport strategy once we release 9.0.\n\n### Identify risks\n\n- [ ] Some deps like `@elastic/elasticsearch` might be bumped to 9.0 and\nshouldn't be backported. We'll update the renovate file when that\noccurs.","sha":"997884e1ba14a4e68647f13b90b7a9337c20d35a"}}]}] BACKPORT-->
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
## Summary Speaking to @azasypkin, we noticed that we are not backporting many of our dependency updates. These were mostly set to `backport:skip` before the 9 vs. 8.x branch split. But we need it at the moment. We'll need to revisit our backport strategy once we release 9.0. ### Identify risks - [ ] Some deps like `@elastic/elasticsearch` might be bumped to 9.0 and shouldn't be backported. We'll update the renovate file when that occurs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Speaking to @azasypkin, we noticed that we are not backporting many of our dependency updates. These were mostly set to
backport:skipbefore the 9 vs. 8.x branch split. But we need it at the moment.We'll need to revisit our backport strategy once we release 9.0.
Identify risks
@elastic/elasticsearchmight be bumped to 9.0 and shouldn't be backported. We'll update the renovate file when that occurs.