[ES|QL] Give the ability to disable the autofocus on the editor #204706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
added
v9.0.0
backport:version
💚 Build Succeeded
Metrics [docs]Async chunks
|
|
Pinging @elastic/kibana-esql (Team:ESQL) |
vadimkibana
approved these changes
Dec 19, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12409976273 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 19, 2024
…tic#204706) ## Summary Right now, the editor autofocuses by default. But there are cases that a consumer won't want this (autofocus might trigger the suggestions). This PR introduces a new property which allows the consumers to disable this feature. (I need this for the ES|QL variables feature) (cherry picked from commit 65437c4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 19, 2024
…#204706) (#204897) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Give the ability to disable the autofocus on the editor (#204706)](#204706) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T09:33:21Z","message":"[ES|QL] Give the ability to disable the autofocus on the editor (#204706)\n\n## Summary\r\n\r\nRight now, the editor autofocuses by default. But there are cases that a\r\nconsumer won't want this (autofocus might trigger the suggestions).\r\n\r\nThis PR introduces a new property which allows the consumers to disable\r\nthis feature.\r\n\r\n(I need this for the ES|QL variables feature)","sha":"65437c4499a8a3627a2dc900f20d261666eeb27e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Feature:ES|QL","Team:ESQL","backport:version","v8.18.0"],"title":"[ES|QL] Give the ability to disable the autofocus on the editor","number":204706,"url":"https://github.com/elastic/kibana/pull/204706","mergeCommit":{"message":"[ES|QL] Give the ability to disable the autofocus on the editor (#204706)\n\n## Summary\r\n\r\nRight now, the editor autofocuses by default. But there are cases that a\r\nconsumer won't want this (autofocus might trigger the suggestions).\r\n\r\nThis PR introduces a new property which allows the consumers to disable\r\nthis feature.\r\n\r\n(I need this for the ES|QL variables feature)","sha":"65437c4499a8a3627a2dc900f20d261666eeb27e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204706","number":204706,"mergeCommit":{"message":"[ES|QL] Give the ability to disable the autofocus on the editor (#204706)\n\n## Summary\r\n\r\nRight now, the editor autofocuses by default. But there are cases that a\r\nconsumer won't want this (autofocus might trigger the suggestions).\r\n\r\nThis PR introduces a new property which allows the consumers to disable\r\nthis feature.\r\n\r\n(I need this for the ES|QL variables feature)","sha":"65437c4499a8a3627a2dc900f20d261666eeb27e"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <[email protected]>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
…tic#204706) ## Summary Right now, the editor autofocuses by default. But there are cases that a consumer won't want this (autofocus might trigger the suggestions). This PR introduces a new property which allows the consumers to disable this feature. (I need this for the ES|QL variables feature)
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Jan 2, 2025
…tic#204706) ## Summary Right now, the editor autofocuses by default. But there are cases that a consumer won't want this (autofocus might trigger the suggestions). This PR introduces a new property which allows the consumers to disable this feature. (I need this for the ES|QL variables feature)
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
…tic#204706) ## Summary Right now, the editor autofocuses by default. But there are cases that a consumer won't want this (autofocus might trigger the suggestions). This PR introduces a new property which allows the consumers to disable this feature. (I need this for the ES|QL variables feature)
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…tic#204706) ## Summary Right now, the editor autofocuses by default. But there are cases that a consumer won't want this (autofocus might trigger the suggestions). This PR introduces a new property which allows the consumers to disable this feature. (I need this for the ES|QL variables feature)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Right now, the editor autofocuses by default. But there are cases that a consumer won't want this (autofocus might trigger the suggestions).
This PR introduces a new property which allows the consumers to disable this feature.
(I need this for the ES|QL variables feature)