-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloud Security] Move @kbn/cloud-security-posture-storybook-config for Kibana sustainability #204500
Conversation
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started a build with the storybooks label to double check we're good.
Thanks @Ikuni17, I was not aware of that label. |
/ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
thanks @seanrathier
@Ikuni17 here is the build with the storybook label I am curious about where the Storybook is published/uploaded. |
💚 Build Succeeded
Metrics [docs]
History
cc @seanrathier |
@seanrathier checkout the last build comment You have a reference to it |
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12392644565 |
…r Kibana sustainability (elastic#204500) ## Summary Move @kbn/cloud-security-posture-storybook-config package to `x-pack/solutions/security/packages/kbn-cloud-security-posture/.storybook` Renamed removed the `config` folder to align with the `.storybook` [naming convention](https://github.com/elastic/kibana/pull/204500/files#diff-91918a63f6365a8f40f674ab54a8df7ce9aeb313f77fe8eda76284d712ef5425R21). ![Screenshot 2024-12-16 at 5 50 53 PM](https://github.com/user-attachments/assets/de1d0a81-353f-434c-bb2d-989210b35b43) ### Related Issues - elastic#202862 --------- Co-authored-by: Brad White <[email protected]> (cherry picked from commit d6cb398)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…fig for Kibana sustainability (#204500) (#204736) # Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security] Move @kbn/cloud-security-posture-storybook-config for Kibana sustainability (#204500)](#204500) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"seanrathier","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-18T12:09:38Z","message":"[Cloud Security] Move @kbn/cloud-security-posture-storybook-config for Kibana sustainability (#204500)\n\n## Summary\r\n\r\nMove @kbn/cloud-security-posture-storybook-config package to\r\n`x-pack/solutions/security/packages/kbn-cloud-security-posture/.storybook`\r\n\r\nRenamed removed the `config` folder to align with the `.storybook`\r\n[naming\r\nconvention](https://github.com/elastic/kibana/pull/204500/files#diff-91918a63f6365a8f40f674ab54a8df7ce9aeb313f77fe8eda76284d712ef5425R21).\r\n\r\n![Screenshot 2024-12-16 at 5 50\r\n53 PM](https://github.com/user-attachments/assets/de1d0a81-353f-434c-bb2d-989210b35b43)\r\n\r\n### Related Issues\r\n- https://github.com/elastic/kibana/pull/202862\r\n\r\n---------\r\n\r\nCo-authored-by: Brad White <[email protected]>","sha":"d6cb398d1ab09af93369e84f0aa13f0688357082","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","backport:prev-minor","ci:build-storybooks"],"title":"[Cloud Security] Move @kbn/cloud-security-posture-storybook-config for Kibana sustainability ","number":204500,"url":"https://github.com/elastic/kibana/pull/204500","mergeCommit":{"message":"[Cloud Security] Move @kbn/cloud-security-posture-storybook-config for Kibana sustainability (#204500)\n\n## Summary\r\n\r\nMove @kbn/cloud-security-posture-storybook-config package to\r\n`x-pack/solutions/security/packages/kbn-cloud-security-posture/.storybook`\r\n\r\nRenamed removed the `config` folder to align with the `.storybook`\r\n[naming\r\nconvention](https://github.com/elastic/kibana/pull/204500/files#diff-91918a63f6365a8f40f674ab54a8df7ce9aeb313f77fe8eda76284d712ef5425R21).\r\n\r\n![Screenshot 2024-12-16 at 5 50\r\n53 PM](https://github.com/user-attachments/assets/de1d0a81-353f-434c-bb2d-989210b35b43)\r\n\r\n### Related Issues\r\n- https://github.com/elastic/kibana/pull/202862\r\n\r\n---------\r\n\r\nCo-authored-by: Brad White <[email protected]>","sha":"d6cb398d1ab09af93369e84f0aa13f0688357082"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204500","number":204500,"mergeCommit":{"message":"[Cloud Security] Move @kbn/cloud-security-posture-storybook-config for Kibana sustainability (#204500)\n\n## Summary\r\n\r\nMove @kbn/cloud-security-posture-storybook-config package to\r\n`x-pack/solutions/security/packages/kbn-cloud-security-posture/.storybook`\r\n\r\nRenamed removed the `config` folder to align with the `.storybook`\r\n[naming\r\nconvention](https://github.com/elastic/kibana/pull/204500/files#diff-91918a63f6365a8f40f674ab54a8df7ce9aeb313f77fe8eda76284d712ef5425R21).\r\n\r\n![Screenshot 2024-12-16 at 5 50\r\n53 PM](https://github.com/user-attachments/assets/de1d0a81-353f-434c-bb2d-989210b35b43)\r\n\r\n### Related Issues\r\n- https://github.com/elastic/kibana/pull/202862\r\n\r\n---------\r\n\r\nCo-authored-by: Brad White <[email protected]>","sha":"d6cb398d1ab09af93369e84f0aa13f0688357082"}}]}] BACKPORT--> Co-authored-by: seanrathier <[email protected]>
Summary
Move @kbn/cloud-security-posture-storybook-config package to
x-pack/solutions/security/packages/kbn-cloud-security-posture/.storybook
Renamed removed the
config
folder to align with the.storybook
naming convention.Related Issues
@elastic/kibana-cloud-security-posture
#202862