Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] Move @kbn/cloud-security-posture-storybook-config for Kibana sustainability #204500

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

seanrathier
Copy link
Contributor

@seanrathier seanrathier commented Dec 16, 2024

Summary

Move @kbn/cloud-security-posture-storybook-config package to x-pack/solutions/security/packages/kbn-cloud-security-posture/.storybook

Renamed removed the config folder to align with the .storybook naming convention.

Screenshot 2024-12-16 at 5 50 53 PM

Related Issues

@seanrathier seanrathier added release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 16, 2024
@seanrathier seanrathier requested review from a team as code owners December 16, 2024 22:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@seanrathier seanrathier self-assigned this Dec 16, 2024
Copy link
Contributor

@opauloh opauloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@Ikuni17 Ikuni17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started a build with the storybooks label to double check we're good.

@seanrathier
Copy link
Contributor Author

I started a build with the storybooks label to double check we're good.

Thanks @Ikuni17, I was not aware of that label.

@seanrathier
Copy link
Contributor Author

/ci

@seanrathier seanrathier enabled auto-merge (squash) December 17, 2024 01:02
Copy link
Contributor

@kfirpeled kfirpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks @seanrathier

@seanrathier
Copy link
Contributor Author

@Ikuni17 here is the build with the storybook label

I am curious about where the Storybook is published/uploaded.

@seanrathier seanrathier requested review from Ikuni17 and removed request for Ikuni17 December 17, 2024 14:30
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @seanrathier

@kfirpeled
Copy link
Contributor

@seanrathier checkout the last build comment

You have a reference to it

Storybooks Preview

@kfirpeled kfirpeled merged commit d6cb398 into elastic:main Dec 18, 2024
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12392644565

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 18, 2024
…r Kibana sustainability (elastic#204500)

## Summary

Move @kbn/cloud-security-posture-storybook-config package to
`x-pack/solutions/security/packages/kbn-cloud-security-posture/.storybook`

Renamed removed the `config` folder to align with the `.storybook`
[naming
convention](https://github.com/elastic/kibana/pull/204500/files#diff-91918a63f6365a8f40f674ab54a8df7ce9aeb313f77fe8eda76284d712ef5425R21).

![Screenshot 2024-12-16 at 5 50
53 PM](https://github.com/user-attachments/assets/de1d0a81-353f-434c-bb2d-989210b35b43)

### Related Issues
- elastic#202862

---------

Co-authored-by: Brad White <[email protected]>
(cherry picked from commit d6cb398)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 18, 2024
…fig for Kibana sustainability (#204500) (#204736)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Cloud Security] Move @kbn/cloud-security-posture-storybook-config
for Kibana sustainability
(#204500)](#204500)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"seanrathier","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-18T12:09:38Z","message":"[Cloud
Security] Move @kbn/cloud-security-posture-storybook-config for Kibana
sustainability (#204500)\n\n## Summary\r\n\r\nMove
@kbn/cloud-security-posture-storybook-config package
to\r\n`x-pack/solutions/security/packages/kbn-cloud-security-posture/.storybook`\r\n\r\nRenamed
removed the `config` folder to align with the
`.storybook`\r\n[naming\r\nconvention](https://github.com/elastic/kibana/pull/204500/files#diff-91918a63f6365a8f40f674ab54a8df7ce9aeb313f77fe8eda76284d712ef5425R21).\r\n\r\n![Screenshot
2024-12-16 at 5
50\r\n53 PM](https://github.com/user-attachments/assets/de1d0a81-353f-434c-bb2d-989210b35b43)\r\n\r\n###
Related Issues\r\n-
https://github.com/elastic/kibana/pull/202862\r\n\r\n---------\r\n\r\nCo-authored-by:
Brad White
<[email protected]>","sha":"d6cb398d1ab09af93369e84f0aa13f0688357082","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud
Security","backport:prev-minor","ci:build-storybooks"],"title":"[Cloud
Security] Move @kbn/cloud-security-posture-storybook-config for Kibana
sustainability
","number":204500,"url":"https://github.com/elastic/kibana/pull/204500","mergeCommit":{"message":"[Cloud
Security] Move @kbn/cloud-security-posture-storybook-config for Kibana
sustainability (#204500)\n\n## Summary\r\n\r\nMove
@kbn/cloud-security-posture-storybook-config package
to\r\n`x-pack/solutions/security/packages/kbn-cloud-security-posture/.storybook`\r\n\r\nRenamed
removed the `config` folder to align with the
`.storybook`\r\n[naming\r\nconvention](https://github.com/elastic/kibana/pull/204500/files#diff-91918a63f6365a8f40f674ab54a8df7ce9aeb313f77fe8eda76284d712ef5425R21).\r\n\r\n![Screenshot
2024-12-16 at 5
50\r\n53 PM](https://github.com/user-attachments/assets/de1d0a81-353f-434c-bb2d-989210b35b43)\r\n\r\n###
Related Issues\r\n-
https://github.com/elastic/kibana/pull/202862\r\n\r\n---------\r\n\r\nCo-authored-by:
Brad White
<[email protected]>","sha":"d6cb398d1ab09af93369e84f0aa13f0688357082"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204500","number":204500,"mergeCommit":{"message":"[Cloud
Security] Move @kbn/cloud-security-posture-storybook-config for Kibana
sustainability (#204500)\n\n## Summary\r\n\r\nMove
@kbn/cloud-security-posture-storybook-config package
to\r\n`x-pack/solutions/security/packages/kbn-cloud-security-posture/.storybook`\r\n\r\nRenamed
removed the `config` folder to align with the
`.storybook`\r\n[naming\r\nconvention](https://github.com/elastic/kibana/pull/204500/files#diff-91918a63f6365a8f40f674ab54a8df7ce9aeb313f77fe8eda76284d712ef5425R21).\r\n\r\n![Screenshot
2024-12-16 at 5
50\r\n53 PM](https://github.com/user-attachments/assets/de1d0a81-353f-434c-bb2d-989210b35b43)\r\n\r\n###
Related Issues\r\n-
https://github.com/elastic/kibana/pull/202862\r\n\r\n---------\r\n\r\nCo-authored-by:
Brad White
<[email protected]>","sha":"d6cb398d1ab09af93369e84f0aa13f0688357082"}}]}]
BACKPORT-->

Co-authored-by: seanrathier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:build-storybooks release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants