[kbn-grid-layout] EUI Visual Refresh Integration #204445
Open
+38
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqliu1
changed the title
cqliu1
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
cqliu1
added
Project:Collapsable Panels
Heenawter
reviewed
Dec 18, 2024
| top: -${euiTheme.size.l}; | ||
| width: ${euiTheme.size.l}; | ||
| height: ${euiTheme.size.l}; | ||
| z-index: ${euiTheme.levels.mask}; // TODO: double check this |
There was a problem hiding this comment.
Do you still need to double check this?
Heenawter
reviewed
Dec 18, 2024
Use backgroundLightAccentSecondary Co-authored-by: Hannah Mudge <[email protected]>
…ttps://github.com/cqliu1/kibana into borealis/kbn-grid-layout/replace-euiThemeVars-usage
…s/kbn-grid-layout/replace-euiThemeVars-usage
…s/kbn-grid-layout/replace-euiThemeVars-usage
…s/kbn-grid-layout/replace-euiThemeVars-usage
…ttps://github.com/cqliu1/kibana into borealis/kbn-grid-layout/replace-euiThemeVars-usage
…s/kbn-grid-layout/replace-euiThemeVars-usage
cqliu1
commented
Dec 27, 2024
| top: -${euiThemeVars.euiSizeL}; | ||
| width: ${euiThemeVars.euiSizeL}; | ||
| height: ${euiThemeVars.euiSizeL}; | ||
| z-index: ${euiThemeVars.euiZLevel3}; |
There was a problem hiding this comment.
@Heenawter Can you confirm if it's okay to remove this z-index from the drag handle? From what I could tell testing locally, the z-index isn't doing anything here.
💚 Build Succeeded
Metrics [docs]
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #203132.
Closes #204592.
This replaces all references to euiThemeVars in favor of the useEuiTheme hook in the
kbn-grid-layoutpackage.Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.